Bug 141248 - [WinCairo] Crash when media player is destroyed.
Summary: [WinCairo] Crash when media player is destroyed.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-04 07:40 PST by peavo
Modified: 2015-02-23 07:22 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.34 KB, patch)
2015-02-04 07:44 PST, peavo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2015-02-04 07:40:55 PST 
A COM smart pointer is both released, and set to null. This means that the COM Release method is called twice, causing a crash.
Comment 1 peavo 2015-02-04 07:44:44 PST 
Created attachment 246032 [details]
Patch
Comment 2 Darin Adler 2015-02-04 09:19:37 PST 
Comment on attachment 246032 [details]
Patch

I remember we found some trick to make it impossible to call deref() on a RefPtr, but I don’t remember what it was or if we did it.
Comment 3 peavo 2015-02-04 09:54:25 PST 
(In reply to comment #2)
> Comment on attachment 246032 [details]
> Patch
> 
> I remember we found some trick to make it impossible to call deref() on a
> RefPtr, but I don’t remember what it was or if we did it.

I see, would be nice to have that in the COMPtr class aswell.

Thanks for reviewing :)
Comment 4 peavo 2015-02-23 06:31:39 PST 
cq+ ? ;)
Comment 5 WebKit Commit Bot 2015-02-23 07:22:16 PST 
Comment on attachment 246032 [details]
Patch

Clearing flags on attachment: 246032

Committed r180501: <http://trac.webkit.org/changeset/180501>
Comment 6 WebKit Commit Bot 2015-02-23 07:22:22 PST 
All reviewed patches have been landed.  Closing bug.