Bug 141236 - When tests fail on leaks bot so much that there are no leaks detected, dashboard erroneously shows green
Summary: When tests fail on leaks bot so much that there are no leaks detected, dashbo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-03 23:44 PST by Alexey Proskuryakov
Modified: 2015-02-04 10:00 PST (History)
1 user (show)

See Also:

Attachments
proposed fix (2.04 KB, patch)
2015-02-03 23:47 PST, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2015-02-03 23:44:42 PST 
Right now, leaks bot fails with the below error and no leaks:

"Exiting early after 50 crashes and 0 timeouts. 2655 tests run. 50 failures"

This shouldn't be green.
Comment 1 Alexey Proskuryakov 2015-02-03 23:47:59 PST 
Created attachment 246022 [details]
proposed fix

If we ever get the leaks bot to a state where there are no leaks at all, but failures do happen, this can be further tweaked to not show orange. This is too far away into the future to care about now.
Comment 2 WebKit Commit Bot 2015-02-04 10:00:05 PST 
Comment on attachment 246022 [details]
proposed fix

Clearing flags on attachment: 246022

Committed r179608: <http://trac.webkit.org/changeset/179608>
Comment 3 WebKit Commit Bot 2015-02-04 10:00:08 PST 
All reviewed patches have been landed.  Closing bug.