Bug 141232 – Web Inspector: Populate Debugger sidebar with all debuggable resources

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

Display all debuggable resources in the Debugger sidebar. Debuggable resources include JS files, HTML files with in inline JS, and transpiled files such as CoffeeScript and TypeScript.

Currently, we only display files what already have breakpoints.

There should also be a filter icon to only show resources with breakpoints.

The idea originated in https://bugs.webkit.org/show_bug.cgi?id=139526#c17.

[Radar WebKit Bug Importer]

<rdar://problem/19711872>

[Jonathan Wells]

<rdar://problem/19523709>

[Jonathan Wells]

Created attachment 247536 [details]
[PATCH] Progress patch for feedback.

Please review progress so far. Screenshot to follow. Working on isolating evaled scripts generated by the WebInspector front-end from those generated by the user's code.

[Jonathan Wells]

Created attachment 247537 [details]
[SCREENSHOT] all scripts in the debugger sidebar

[Nikita Vasilyev]

First of all, it works and it feels just right staying in the debugger to open JS files.

https://cldup.com/gJCylgVnzW-3000x3000.png

I noticed ~50 anonymous scripts on http://n12v.com. I don’t even know where are they coming from. Can we move them into a separate directory, same way it’s done in the resources sidebar?

[Nikita Vasilyev]

Comment on attachment 247536 [details]
[PATCH] Progress patch for feedback.

View in context: https://bugs.webkit.org/attachment.cgi?id=247536&action=review

> Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:348
> +        // filter out those that were generated by the console.

https://bugs.webkit.org/show_bug.cgi?id=142123

[Timothy Hatcher]

Comment on attachment 247536 [details]
[PATCH] Progress patch for feedback.

View in context: https://bugs.webkit.org/attachment.cgi?id=247536&action=review

Overall the patch looks good.

> Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:353
> +        // if (!script.url)
> +        //     return;

We should hide Anonymous Scripts for now. Then we can add support after filtering in in place.

[Jonathan Wells]

Created attachment 247980 [details]
[PATCH] Fix.

[Timothy Hatcher]

Comment on attachment 247980 [details]
[PATCH] Fix.

View in context: https://bugs.webkit.org/attachment.cgi?id=247980&action=review

> Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:332
> +        this._getTreeElementForSourceCodeAndAddToContentTreeOutline(resource);

_addTreeElementForSourceCodeToContentTreeOutline would be a better name, since we don't always use the result.

[Jonathan Wells]

Comment on attachment 247980 [details]
[PATCH] Fix.

View in context: https://bugs.webkit.org/attachment.cgi?id=247980&action=review

>> Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:332
>> +        this._getTreeElementForSourceCodeAndAddToContentTreeOutline(resource);
> 
> _addTreeElementForSourceCodeToContentTreeOutline would be a better name, since we don't always use the result.

That's much better.

[Jonathan Wells]

Created attachment 248083 [details]
[PATCH] Fix with additions for removing breakpoints.

I forgot to consider removing breakpoints. It was still the case that removing all breakpoints from a resource would cause the resource to be removed from the sidebar. This has been fixed with a change in TreeOutline.js and a small change to DebuggerSidebarPanel.js.

[Timothy Hatcher]

Comment on attachment 248083 [details]
[PATCH] Fix with additions for removing breakpoints.

View in context: https://bugs.webkit.org/attachment.cgi?id=248083&action=review

> Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:329
> +        if ([WebInspector.Resource.Type.Document, WebInspector.Resource.Type.Script].indexOf(resource.type) < 0)

Nit: .contains(resource.type) would be better.

[Jonathan Wells]

Committed r181184: <http://trac.webkit.org/changeset/181184>

[Jonathan Wells]

Reopening to attach new patch.

[Jonathan Wells]

Created attachment 248530 [details]
Patch, MISTAKENLY UPLOADED HERE

[Jonathan Wells]

Mistakenly uploaded patch from another bug.