Bug 141226 - Don’t use repository names as id’s.
Summary: Don’t use repository names as id’s.
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Website (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
Depends on: 141220
Blocks: 138516
  Show dependency treegraph
Reported: 2015-02-03 17:46 PST by Ryosuke Niwa
Modified: 2015-02-03 21:40 PST (History)
0 users

See Also:

Refactoring (14.64 KB, patch)
2015-02-03 17:58 PST, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Fixed the patch (15.91 KB, patch)
2015-02-03 18:06 PST, Ryosuke Niwa
cdumez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2015-02-03 17:46:58 PST
Right now, the perf dashboard uses the repository names as repository id’s.
This forces runs.php to run an unnecessary SQL query on every request.
Don’t do that.
Comment 1 Ryosuke Niwa 2015-02-03 17:58:11 PST
Created attachment 245999 [details]
Comment 2 Ryosuke Niwa 2015-02-03 18:06:05 PST
Created attachment 246004 [details]
Fixed the patch
Comment 3 Chris Dumez 2015-02-03 19:10:03 PST
Comment on attachment 246004 [details]
Fixed the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246004&action=review


> Websites/perf.webkit.org/ChangeLog:9
> +        Since names of repositories are available in manifest.json, we can resole their names in the front end.

Comment 4 Ryosuke Niwa 2015-02-03 21:40:09 PST
Thanks for the review!
Comment 5 Ryosuke Niwa 2015-02-03 21:40:36 PST
Committed r179591: <http://trac.webkit.org/changeset/179591>