Bug 141224 - Every PageOverlayClientImpl leaks
Summary: Every PageOverlayClientImpl leaks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-03 17:40 PST by Tim Horton
Modified: 2015-02-03 17:58 PST (History)
4 users (show)

See Also:

Attachments
Patch (9.16 KB, patch)
2015-02-03 17:40 PST, Tim Horton 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-02-03 17:40:33 PST 
Every PageOverlayClientImpl leaks
Comment 1 Tim Horton 2015-02-03 17:40:51 PST 
Created attachment 245997 [details]
Patch
Comment 2 Tim Horton 2015-02-03 17:41:15 PST 
rdar://problem/19652939
Comment 3 Simon Fraser (smfr) 2015-02-03 17:51:24 PST 
Comment on attachment 245997 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245997&action=review

> Source/WebKit2/WebProcess/WebPage/WebPageOverlay.h:105
> +    std::unique_ptr<Client> m_client;

It's weird for thing to own its client, but perhaps this isn't a client in the normal sense.
Comment 4 Tim Horton 2015-02-03 17:56:42 PST 
(In reply to comment #3)
> Comment on attachment 245997 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=245997&action=review
> 
> > Source/WebKit2/WebProcess/WebPage/WebPageOverlay.h:105
> > +    std::unique_ptr<Client> m_client;
> 
> It's weird for thing to own its client, but perhaps this isn't a client in
> the normal sense.

These are internal-ish client wrapper-ish things; it's not that weird, all of the API clients (Loader, Policy, etc.) on WKPage work exactly the same way.
Comment 5 Tim Horton 2015-02-03 17:58:37 PST 
http://trac.webkit.org/changeset/179586