Bug 141219 - video.controls should not return true just because of fullscreen
Summary: video.controls should not return true just because of fullscreen
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-02-03 16:42 PST by Eric Carlson
Modified: 2015-02-04 10:16 PST (History)
2 users (show)

See Also:

Attachments
Proposed patch. (5.95 KB, patch)
2015-02-03 18:01 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2015-02-03 16:42:32 PST 
HTMLMediaElement::controls always returns true when an element is in fullscreen. While it may be necessary to show native controls when in fullscreen, video.controls should reflect the attribute value.
Comment 1 Eric Carlson 2015-02-03 16:43:50 PST 
<rdar://problem/19237142>
Comment 2 Eric Carlson 2015-02-03 18:01:19 PST 
Created attachment 246002 [details]
Proposed patch.
Comment 3 Dean Jackson 2015-02-04 08:24:36 PST 
Comment on attachment 246002 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=246002&action=review

> Source/WebCore/ChangeLog:3
> +        video.attribute should not return true just because of fullscreen

Should this be "video.controls"?
Comment 4 WebKit Commit Bot 2015-02-04 10:16:12 PST 
Comment on attachment 246002 [details]
Proposed patch.

Clearing flags on attachment: 246002

Committed r179612: <http://trac.webkit.org/changeset/179612>
Comment 5 WebKit Commit Bot 2015-02-04 10:16:16 PST 
All reviewed patches have been landed.  Closing bug.