Bug 141217 - Add WKPageNavigationClient as C SPI around API::NavigationClient, and adopt in WKTR
Summary: Add WKPageNavigationClient as C SPI around API::NavigationClient, and adopt i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on: 141233
Blocks:
  Show dependency treegraph
 
Reported: 2015-02-03 16:23 PST by Tim Horton
Modified: 2015-02-04 01:29 PST (History)
5 users (show)

See Also:


Attachments
Patch (89.74 KB, patch)
2015-02-03 16:24 PST, Tim Horton
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-02-03 16:23:25 PST
Add WKPageNavigationClient as C SPI around API::NavigationClient, and adopt in WKTR
Comment 1 Tim Horton 2015-02-03 16:24:25 PST
Created attachment 245986 [details]
Patch
Comment 2 Sam Weinig 2015-02-03 18:20:57 PST
Comment on attachment 245986 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245986&action=review

> Source/WebKit2/UIProcess/API/C/WKPage.h:217
>  WK_EXPORT void WKPageSetPageLoaderClient(WKPageRef page, const WKPageLoaderClientBase* client);
> +WK_EXPORT void WKPageSetPageNavigationClient(WKPageRef page, const WKPageNavigationClientBase* client);

I think it would valuable to add a comment here explaining that you can either use WKPageSetPageNavigationClient or WKPageSetPageLoaderClient/WKPageSetPageLoaderClient.

> Tools/WebKitTestRunner/TestController.cpp:97
> +static WKDataRef copyWebCryptoMasterKey(WKContextRef, const void*)
> +{
> +    return copyWebCryptoMasterKey();
> +}

Why do we still need the Context variant of this in WKTR?
Comment 3 Tim Horton 2015-02-03 19:17:01 PST
(In reply to comment #2)
> Comment on attachment 245986 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=245986&action=review
> 
> > Source/WebKit2/UIProcess/API/C/WKPage.h:217
> >  WK_EXPORT void WKPageSetPageLoaderClient(WKPageRef page, const WKPageLoaderClientBase* client);
> > +WK_EXPORT void WKPageSetPageNavigationClient(WKPageRef page, const WKPageNavigationClientBase* client);
> 
> I think it would valuable to add a comment here explaining that you can
> either use WKPageSetPageNavigationClient or
> WKPageSetPageLoaderClient/WKPageSetPageLoaderClient.

Sure!

> > Tools/WebKitTestRunner/TestController.cpp:97
> > +static WKDataRef copyWebCryptoMasterKey(WKContextRef, const void*)
> > +{
> > +    return copyWebCryptoMasterKey();
> > +}
> 
> Why do we still need the Context variant of this in WKTR?

I don't think we do; good point!
Comment 4 Tim Horton 2015-02-03 20:03:15 PST
http://trac.webkit.org/changeset/179588
Comment 5 Tim Horton 2015-02-03 20:04:00 PST
Oh dear, #import. Will fix.
Comment 6 Tim Horton 2015-02-03 20:06:51 PST
http://trac.webkit.org/changeset/179589
Comment 7 Simon Fraser (smfr) 2015-02-03 22:45:29 PST
This broke both GTK and EFL (as the EWS show).
Comment 8 Chris Dumez 2015-02-03 23:11:56 PST
(In reply to comment #7)
> This broke both GTK and EFL (as the EWS show).

Fixed in https://trac.webkit.org/changeset/179596.
Comment 9 Tim Horton 2015-02-03 23:33:45 PST
(In reply to comment #7)
> This broke both GTK and EFL (as the EWS show).

The failure I saw in EWS was fixed in r179589 but obviously wasn't the only problem. That said, WebKit2 yaddayadda.