Bug 141216 - [iOS] Add support for deleteFromInputWithFlags
Summary: [iOS] Add support for deleteFromInputWithFlags
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Enrica Casucci
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-02-03 15:46 PST by Enrica Casucci
Modified: 2016-06-02 15:52 PDT (History)
1 user (show)

See Also:


Attachments
Patch (8.54 KB, patch)
2015-02-03 15:51 PST, Enrica Casucci
benjamin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Enrica Casucci 2015-02-03 15:46:58 PST
UIKit is adopting a new way to handle delete from input.
This bug track the work required in WebKit to adopt the new method.
Comment 1 Enrica Casucci 2015-02-03 15:51:41 PST
Created attachment 245981 [details]
Patch
Comment 2 Benjamin Poulain 2015-02-03 16:11:21 PST
Comment on attachment 245981 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245981&action=review

rs=me

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2420
> +            // FIXME: remove deleteFromInput once UIKit adopts deleteFromInputWithFlags
> +            if ([[UIKeyboardImpl sharedInstance] respondsToSelector:@selector(deleteFromInputWithFlags:)])
> +                [[UIKeyboardImpl sharedInstance] deleteFromInputWithFlags:event.keyboardFlags];
> +            else
> +                [[UIKeyboardImpl sharedInstance] deleteFromInput];

Let's store the object from [UIKeyboardImpl sharedInstance] in a temp variable.

Is the new call gonna link?

> Source/WebKit/ios/WebView/WebUIKitDelegate.h:81
> +// FIXME: to be removed when UIKit implements the new one below.

Maybe say "deleteFromInput" is to be removed? Comments tends to move in WebKit :)

> Source/WebKit/mac/WebView/WebHTMLView.mm:5827
> +                        if ([[self _webView] respondsToSelector:@selector(deleteFromInputWithFlags:)])

[self _webView] in a temp?
Comment 3 Enrica Casucci 2015-02-03 16:13:28 PST
> Is the new call gonna link?
> 
Yes, I added it at the top of the file for staging.
Comment 4 David Kilzer (:ddkilzer) 2016-06-02 15:51:43 PDT
This landed long ago in r179580:
<http://trac.webkit.org/r179580>
Comment 5 David Kilzer (:ddkilzer) 2016-06-02 15:52:23 PDT
<rdar://problem/19130081>