Bug 141216 – [iOS] Add support for deleteFromInputWithFlags

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Enrica Casucci]

UIKit is adopting a new way to handle delete from input.
This bug track the work required in WebKit to adopt the new method.

[Enrica Casucci]

Created attachment 245981 [details]
Patch

[Benjamin Poulain]

Comment on attachment 245981 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245981&action=review

rs=me

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2420
> +            // FIXME: remove deleteFromInput once UIKit adopts deleteFromInputWithFlags
> +            if ([[UIKeyboardImpl sharedInstance] respondsToSelector:@selector(deleteFromInputWithFlags:)])
> +                [[UIKeyboardImpl sharedInstance] deleteFromInputWithFlags:event.keyboardFlags];
> +            else
> +                [[UIKeyboardImpl sharedInstance] deleteFromInput];

Let's store the object from [UIKeyboardImpl sharedInstance] in a temp variable.

Is the new call gonna link?

> Source/WebKit/ios/WebView/WebUIKitDelegate.h:81
> +// FIXME: to be removed when UIKit implements the new one below.

Maybe say "deleteFromInput" is to be removed? Comments tends to move in WebKit :)

> Source/WebKit/mac/WebView/WebHTMLView.mm:5827
> +                        if ([[self _webView] respondsToSelector:@selector(deleteFromInputWithFlags:)])

[self _webView] in a temp?

[Enrica Casucci]

> Is the new call gonna link?
> 
Yes, I added it at the top of the file for staging.

[David Kilzer (:ddkilzer)]

This landed long ago in r179580:
<http://trac.webkit.org/r179580>

[David Kilzer (:ddkilzer)]

<rdar://problem/19130081>