Bug 141212 – Crash when printing snapshotted plugins

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Maciej Stachowiak]

Crash when printing snapshotted plugins

[Maciej Stachowiak]

Created attachment 245973 [details]
Patch

[Maciej Stachowiak]

<rdar://problem/18345373>

[Dean Jackson]

Comment on attachment 245973 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245973&action=review

> Source/WebCore/html/HTMLPlugInImageElement.cpp:230
> +
> +
>  bool HTMLPlugInImageElement::willRecalcStyle(Style::Change change)

Nit extra blank line.

> LayoutTests/plugins/snapshotting/print-snapshotted-plugin.html:5
> +    window.internals.settings.setMaximumPlugInSnapshotAttempts(0);

no need for "window".

[Build Bot]

Comment on attachment 245973 [details]
Patch

Attachment 245973 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4872086841458688

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 245976 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 245973 [details]
Patch

Attachment 245973 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6177490879905792

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 245982 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Maciej Stachowiak]

Oops, looks like my patch breaks the world.

[Maciej Stachowiak]

Created attachment 246015 [details]
Revised to not fail tons of tests

[Maciej Stachowiak]

The new patch seems to work, I would appreciate review on the revised version (since I did make a substantive change).

[Simon Fraser (smfr)]

Comment on attachment 246015 [details]
Revised to not fail tons of tests

View in context: https://bugs.webkit.org/attachment.cgi?id=246015&action=review

> Source/WebCore/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Test: plugins/snapshotting/print-snapshotted-plugin.html

The changelog doesn't tell me why it crashed.

> Source/WebCore/ChangeLog:12
> +        method. If the current renderer is a snapshotted plugin, Only

, Only -> , only

[Maciej Stachowiak]

Committed r179597: <http://trac.webkit.org/changeset/179597>