Bug 141212 - Crash when printing snapshotted plugins
Summary: Crash when printing snapshotted plugins
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Maciej Stachowiak
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-02-03 15:02 PST by Maciej Stachowiak
Modified: 2015-02-03 23:01 PST (History)
5 users (show)

See Also:


Attachments
Patch (5.78 KB, patch)
2015-02-03 15:10 PST, Maciej Stachowiak
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-mavericks (504.21 KB, application/zip)
2015-02-03 15:33 PST, Build Bot
no flags Details
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (500.00 KB, application/zip)
2015-02-03 15:58 PST, Build Bot
no flags Details
Revised to not fail tons of tests (6.02 KB, patch)
2015-02-03 21:36 PST, Maciej Stachowiak
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2015-02-03 15:02:04 PST
Crash when printing snapshotted plugins
Comment 1 Maciej Stachowiak 2015-02-03 15:10:05 PST
Created attachment 245973 [details]
Patch
Comment 2 Maciej Stachowiak 2015-02-03 15:11:20 PST
<rdar://problem/18345373>
Comment 3 Dean Jackson 2015-02-03 15:12:04 PST
Comment on attachment 245973 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245973&action=review

> Source/WebCore/html/HTMLPlugInImageElement.cpp:230
> +
> +
>  bool HTMLPlugInImageElement::willRecalcStyle(Style::Change change)

Nit extra blank line.

> LayoutTests/plugins/snapshotting/print-snapshotted-plugin.html:5
> +    window.internals.settings.setMaximumPlugInSnapshotAttempts(0);

no need for "window".
Comment 4 Build Bot 2015-02-03 15:33:45 PST
Comment on attachment 245973 [details]
Patch

Attachment 245973 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4872086841458688

Number of test failures exceeded the failure limit.
Comment 5 Build Bot 2015-02-03 15:33:47 PST
Created attachment 245976 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 6 Build Bot 2015-02-03 15:58:04 PST
Comment on attachment 245973 [details]
Patch

Attachment 245973 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6177490879905792

Number of test failures exceeded the failure limit.
Comment 7 Build Bot 2015-02-03 15:58:06 PST
Created attachment 245982 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 8 Maciej Stachowiak 2015-02-03 16:55:24 PST
Oops, looks like my patch breaks the world.
Comment 9 Maciej Stachowiak 2015-02-03 21:36:02 PST
Created attachment 246015 [details]
Revised to not fail tons of tests
Comment 10 Maciej Stachowiak 2015-02-03 22:31:51 PST
The new patch seems to work, I would appreciate review on the revised version (since I did make a substantive change).
Comment 11 Simon Fraser (smfr) 2015-02-03 22:54:02 PST
Comment on attachment 246015 [details]
Revised to not fail tons of tests

View in context: https://bugs.webkit.org/attachment.cgi?id=246015&action=review

> Source/WebCore/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Test: plugins/snapshotting/print-snapshotted-plugin.html

The changelog doesn't tell me why it crashed.

> Source/WebCore/ChangeLog:12
> +        method. If the current renderer is a snapshotted plugin, Only

, Only -> , only
Comment 12 Maciej Stachowiak 2015-02-03 23:01:26 PST
Committed r179597: <http://trac.webkit.org/changeset/179597>