Bug 141203 - Smart quoting could move the caret backwards in some configurations
Summary: Smart quoting could move the caret backwards in some configurations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-02-03 10:26 PST by Ryosuke Niwa
Modified: 2015-02-03 18:02 PST (History)
3 users (show)

See Also:

Attachments
Fixes the bug (9.55 KB, patch)
2015-02-03 11:06 PST, Ryosuke Niwa 		enrica: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2015-02-03 10:26:44 PST 
When continous spellchecking and text replacement are disabled but smart link is enabled, smart quote could move the caret backwards.

<rdar://problem/17452543>
Comment 1 Ryosuke Niwa 2015-02-03 11:06:31 PST 
Created attachment 245950 [details]
Fixes the bug
Comment 2 Enrica Casucci 2015-02-03 13:33:54 PST 
Comment on attachment 245950 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=245950&action=review

look good to me

> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=141203

Please, add the radar number to the ChangeLog
Comment 3 Ryosuke Niwa 2015-02-03 13:50:02 PST 
Thanks for the review.
Comment 4 Ryosuke Niwa 2015-02-03 13:52:52 PST 
Committed r179569: <http://trac.webkit.org/changeset/179569>
Comment 5 Ryosuke Niwa 2015-02-03 18:02:01 PST 
Added the expected result in http://trac.webkit.org/changeset/179587.