/usr/include/libpng12/png.h:2659:31: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Werror=literal-suffix] fprintf(PNG_DEBUG_FILE,"%s"m PNG_STRING_NEWLINE,(num_tabs==1 ? "\t" : \ ^ /usr/include/libpng12/png.h:2667:31: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Werror=literal-suffix] fprintf(PNG_DEBUG_FILE,"%s"m PNG_STRING_NEWLINE,(num_tabs==1 ? "\t" : \ ^ /usr/include/libpng12/png.h:2675:31: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Werror=literal-suffix] fprintf(PNG_DEBUG_FILE,"%s"m PNG_STRING_NEWLINE,(num_tabs==1 ? "\t" : \ ^ Introduce the build fail after removing the -Wno-error=literal-suffix. My gcc version is gcc (Ubuntu/Linaro 4.8.1-10ubuntu9) 4.8.1. ================= in https://bugs.webkit.org/show_bug.cgi?id=140886 ===================== Comment 1 Csaba Osztrogonác 2015-01-26 05:48:46 PST Created attachment 245344 [details] Patch Let's remove these flags, we don't need them after http://trac.webkit.org/changeset/179110 ========================================================================================== Dear Csaba Osztrogonác, Is it related with the gcc version?
Created attachment 245935 [details] patch
I've same errors and I've uploaded my local patch for all.
Created attachment 245936 [details] patch
Created attachment 245937 [details] patch
No, it isn't related to GCC version, but the non-C++11 compatible libpng version. I assume you still have Ubuntu 13.10, which isn't supported long time ago. https://wiki.ubuntu.com/Releases - End of life of 13.10: July 17, 2014 https://lists.ubuntu.com/archives/ubuntu-announce/2014-June/000185.html I suggest you should upgrade your system or fix your png.h locally, it is only 1-1 space in 3 lines. ;) I don't like the idea to disable literal-suffix warnings for all sources and for GTK and EFL too because of a non supported distribution.
I agree with you that the root cause is the non-C++11 compatible libpng version. Thanks for your feedback.
(In reply to comment #6) > I agree with you that the root cause is the non-C++11 compatible libpng > version. > > Thanks for your feedback. Closed this bug because of Ossy's review. I agree with Ossy's comment.