WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
141188
[EFL] Build failed after
r179113
https://bugs.webkit.org/show_bug.cgi?id=141188
Summary
[EFL] Build failed after r179113
Hunseop Jeong
Reported
2015-02-02 20:37:21 PST
/usr/include/libpng12/png.h:2659:31: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Werror=literal-suffix] fprintf(PNG_DEBUG_FILE,"%s"m PNG_STRING_NEWLINE,(num_tabs==1 ? "\t" : \ ^ /usr/include/libpng12/png.h:2667:31: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Werror=literal-suffix] fprintf(PNG_DEBUG_FILE,"%s"m PNG_STRING_NEWLINE,(num_tabs==1 ? "\t" : \ ^ /usr/include/libpng12/png.h:2675:31: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Werror=literal-suffix] fprintf(PNG_DEBUG_FILE,"%s"m PNG_STRING_NEWLINE,(num_tabs==1 ? "\t" : \ ^ Introduce the build fail after removing the -Wno-error=literal-suffix. My gcc version is gcc (Ubuntu/Linaro 4.8.1-10ubuntu9) 4.8.1. ================= in
https://bugs.webkit.org/show_bug.cgi?id=140886
=====================
Comment 1
Csaba Osztrogonác 2015-01-26 05:48:46 PST Created
attachment 245344
[details]
Patch Let's remove these flags, we don't need them after
http://trac.webkit.org/changeset/179110
========================================================================================== Dear Csaba Osztrogonác, Is it related with the gcc version?
Attachments
patch
(1.24 KB, patch)
2015-02-03 06:18 PST
,
Hyungwook Lee
no flags
Details
Formatted Diff
Diff
patch
(1.19 KB, patch)
2015-02-03 06:23 PST
,
Hyungwook Lee
no flags
Details
Formatted Diff
Diff
patch
(1.25 KB, patch)
2015-02-03 06:25 PST
,
Hyungwook Lee
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Hyungwook Lee
Comment 1
2015-02-03 06:18:43 PST
Created
attachment 245935
[details]
patch
Hyungwook Lee
Comment 2
2015-02-03 06:19:39 PST
I've same errors and I've uploaded my local patch for all.
Hyungwook Lee
Comment 3
2015-02-03 06:23:04 PST
Created
attachment 245936
[details]
patch
Hyungwook Lee
Comment 4
2015-02-03 06:25:00 PST
Created
attachment 245937
[details]
patch
Csaba Osztrogonác
Comment 5
2015-02-03 06:26:37 PST
No, it isn't related to GCC version, but the non-C++11 compatible libpng version. I assume you still have Ubuntu 13.10, which isn't supported long time ago.
https://wiki.ubuntu.com/Releases
- End of life of 13.10: July 17, 2014
https://lists.ubuntu.com/archives/ubuntu-announce/2014-June/000185.html
I suggest you should upgrade your system or fix your png.h locally, it is only 1-1 space in 3 lines. ;) I don't like the idea to disable literal-suffix warnings for all sources and for GTK and EFL too because of a non supported distribution.
Hyungwook Lee
Comment 6
2015-02-03 06:37:36 PST
I agree with you that the root cause is the non-C++11 compatible libpng version. Thanks for your feedback.
Gyuyoung Kim
Comment 7
2015-02-03 07:18:16 PST
(In reply to
comment #6
)
> I agree with you that the root cause is the non-C++11 compatible libpng > version. > > Thanks for your feedback.
Closed this bug because of Ossy's review. I agree with Ossy's comment.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug