Bug 141185 - Web Platform Tests dirty a few untracked files
Summary: Web Platform Tests dirty a few untracked files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-02 19:19 PST by Tim Horton
Modified: 2015-02-03 11:34 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.26 KB, patch)
2015-02-03 04:34 PST, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-02-02 19:19:55 PST
After a "run-webkit-tests -2":


Untracked files:
  (use "git add <file>..." to include in what will be committed)

	LayoutTests/imported/w3c/web-platform-tests/_certs/index.txt
	LayoutTests/imported/w3c/web-platform-tests/tools/scripts/__init__.py
	LayoutTests/imported/w3c/web-platform-tests/tools/webdriver/webdriver/__init__.py


I expect none of this!
Comment 1 Tim Horton 2015-02-02 19:21:04 PST
Youenn, please fix your email address in contributors.json so that autocomplete for you works!
Comment 2 youenn fablet 2015-02-03 00:16:46 PST
(In reply to comment #1)
> Youenn, please fix your email address in contributors.json so that
> autocomplete for you works!

Ah, right, I will fix it!

Regarding the untracked files, the __init.py__ should have been checked in.
It seems webkit infrastructure has some issues with empty files.
Anyway, this should be covered by bug 141030 patch.

I will fix the missing index.txt file.
Comment 3 youenn fablet 2015-02-03 04:34:12 PST
Created attachment 245932 [details]
Patch
Comment 4 WebKit Commit Bot 2015-02-03 09:06:55 PST
Comment on attachment 245932 [details]
Patch

Rejecting attachment 245932 [details] from commit-queue.

youennf@gmail.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 5 youenn fablet 2015-02-03 10:59:17 PST
(In reply to comment #1)
> Youenn, please fix your email address in contributors.json so that
> autocomplete for you works!

Thanks for cq+!
Comment 6 WebKit Commit Bot 2015-02-03 11:34:53 PST
Comment on attachment 245932 [details]
Patch

Clearing flags on attachment: 245932

Committed r179557: <http://trac.webkit.org/changeset/179557>
Comment 7 WebKit Commit Bot 2015-02-03 11:34:56 PST
All reviewed patches have been landed.  Closing bug.