Bug 141176 - [WK2] Drop legacy WKBundlePageDiagnosticLoggingClient API
Summary: [WK2] Drop legacy WKBundlePageDiagnosticLoggingClient API
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 142131
Blocks:
  Show dependency tree / graph
 
Reported: 2015-02-02 14:55 PST by Chris Dumez
Modified: 2015-02-28 10:42 PST (History)
6 users (show)

See Also:

Attachments
Patch (45.48 KB, patch)
2015-02-27 11:07 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (45.50 KB, patch)
2015-02-27 11:46 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-02-02 14:55:47 PST 
Drop legacy WKBundlePageDiagnosticLoggingClient WK2 API as we are now exposing this functionality via WKPageDiagnosticLoggingClient.h on UIProcess side. The client-side has already been ported over.
Comment 1 Chris Dumez 2015-02-23 18:48:46 PST 
We should be able to drop this now.
Comment 2 Chris Dumez 2015-02-27 11:07:58 PST 
Created attachment 247524 [details]
Patch
Comment 3 Chris Dumez 2015-02-27 11:46:44 PST 
Created attachment 247529 [details]
Patch
Comment 4 WebKit Commit Bot 2015-02-27 17:43:44 PST 
Comment on attachment 247529 [details]
Patch

Clearing flags on attachment: 247529

Committed r180804: <http://trac.webkit.org/changeset/180804>
Comment 5 WebKit Commit Bot 2015-02-27 17:43:51 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 David Kilzer (:ddkilzer) 2015-02-27 19:06:10 PST 
Did this break two TestWebKitAPI tests?

Build: <https://build.webkit.org/builders/Apple%20Yosemite%20Release%20WK1%20(Tests)/builds/3211>

Test: <https://build.webkit.org/builders/Apple%20Yosemite%20Release%20WK1%20(Tests)/builds/3211/steps/run-api-tests/logs/stdio>

TIMEOUT _WKDownload.DownloadRequest
TIMEOUT _WKDownload.OriginatingWebView
Comment 7 Chris Dumez 2015-02-27 19:31:43 PST 
(In reply to comment #6)
> Did this break two TestWebKitAPI tests?
> 
> Build:
> <https://build.webkit.org/builders/
> Apple%20Yosemite%20Release%20WK1%20(Tests)/builds/3211>
> 
> Test:
> <https://build.webkit.org/builders/
> Apple%20Yosemite%20Release%20WK1%20(Tests)/builds/3211/steps/run-api-tests/
> logs/stdio>
> 
> TIMEOUT _WKDownload.DownloadRequest
> TIMEOUT _WKDownload.OriginatingWebView

Seems unlikely. Also, it started failing after ryosuke's bmalloc changes, not mine, right?
Comment 8 Chris Dumez 2015-02-27 19:45:05 PST 
(In reply to comment #7)
> (In reply to comment #6)
> > Did this break two TestWebKitAPI tests?
> > 
> > Build:
> > <https://build.webkit.org/builders/
> > Apple%20Yosemite%20Release%20WK1%20(Tests)/builds/3211>
> > 
> > Test:
> > <https://build.webkit.org/builders/
> > Apple%20Yosemite%20Release%20WK1%20(Tests)/builds/3211/steps/run-api-tests/
> > logs/stdio>
> > 
> > TIMEOUT _WKDownload.DownloadRequest
> > TIMEOUT _WKDownload.OriginatingWebView
> 
> Seems unlikely. Also, it started failing after ryosuke's bmalloc changes,
> not mine, right?

The build right after is good:
https://build.webkit.org/builders/Apple%20Yosemite%20Release%20WK1%20%28Tests%29/builds/3212

I guess this was a flake.
Comment 9 Alexey Proskuryakov 2015-02-28 10:33:23 PST 
This broke nightly builds.
Comment 10 WebKit Commit Bot 2015-02-28 10:42:24 PST 
Re-opened since this is blocked by bug 142131