Drop legacy WKBundlePageDiagnosticLoggingClient WK2 API as we are now exposing this functionality via WKPageDiagnosticLoggingClient.h on UIProcess side. The client-side has already been ported over.
We should be able to drop this now.
Created attachment 247524 [details] Patch
Created attachment 247529 [details] Patch
Comment on attachment 247529 [details] Patch Clearing flags on attachment: 247529 Committed r180804: <http://trac.webkit.org/changeset/180804>
All reviewed patches have been landed. Closing bug.
Did this break two TestWebKitAPI tests? Build: <https://build.webkit.org/builders/Apple%20Yosemite%20Release%20WK1%20(Tests)/builds/3211> Test: <https://build.webkit.org/builders/Apple%20Yosemite%20Release%20WK1%20(Tests)/builds/3211/steps/run-api-tests/logs/stdio> TIMEOUT _WKDownload.DownloadRequest TIMEOUT _WKDownload.OriginatingWebView
(In reply to comment #6) > Did this break two TestWebKitAPI tests? > > Build: > <https://build.webkit.org/builders/ > Apple%20Yosemite%20Release%20WK1%20(Tests)/builds/3211> > > Test: > <https://build.webkit.org/builders/ > Apple%20Yosemite%20Release%20WK1%20(Tests)/builds/3211/steps/run-api-tests/ > logs/stdio> > > TIMEOUT _WKDownload.DownloadRequest > TIMEOUT _WKDownload.OriginatingWebView Seems unlikely. Also, it started failing after ryosuke's bmalloc changes, not mine, right?
(In reply to comment #7) > (In reply to comment #6) > > Did this break two TestWebKitAPI tests? > > > > Build: > > <https://build.webkit.org/builders/ > > Apple%20Yosemite%20Release%20WK1%20(Tests)/builds/3211> > > > > Test: > > <https://build.webkit.org/builders/ > > Apple%20Yosemite%20Release%20WK1%20(Tests)/builds/3211/steps/run-api-tests/ > > logs/stdio> > > > > TIMEOUT _WKDownload.DownloadRequest > > TIMEOUT _WKDownload.OriginatingWebView > > Seems unlikely. Also, it started failing after ryosuke's bmalloc changes, > not mine, right? The build right after is good: https://build.webkit.org/builders/Apple%20Yosemite%20Release%20WK1%20%28Tests%29/builds/3212 I guess this was a flake.
This broke nightly builds.
Re-opened since this is blocked by bug 142131