Bug 141170 - Add diagnostic logging for ResourceResponse's source
Summary: Add diagnostic logging for ResourceResponse's source
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-02-02 14:11 PST by Chris Dumez
Modified: 2015-02-02 18:22 PST (History)
5 users (show)

See Also:

Attachments
Patch (6.40 KB, patch)
2015-02-02 14:15 PST, Chris Dumez 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-02-02 14:11:02 PST 
Add diagnostic logging for ResourceResponse's source (network, disk cache, disk cache after validation) to give us an idea of our network cache efficacy. 

Radar: <rdar://problem/19632080>
Comment 1 Chris Dumez 2015-02-02 14:15:09 PST 
Created attachment 245899 [details]
Patch
Comment 2 Antti Koivisto 2015-02-02 17:14:53 PST 
Comment on attachment 245899 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245899&action=review

> Source/WebCore/loader/ResourceLoader.cpp:300
> +static inline void logResourceResponseSource(Frame* frame, ResourceResponseBase::Source source)

inline seems overkill
Comment 3 Antti Koivisto 2015-02-02 17:18:38 PST 
Comment on attachment 245899 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245899&action=review

>> Source/WebCore/loader/ResourceLoader.cpp:300
>> +static inline void logResourceResponseSource(Frame* frame, ResourceResponseBase::Source source)
> 
> inline seems overkill

it is nicer to use ResourceResponse::Source, the Base is just an implementation detail.
Comment 4 Chris Dumez 2015-02-02 18:22:45 PST 
Committed r179533: <http://trac.webkit.org/changeset/179533>