Bug 141169 - REGRESSION(r179477): arguments simplification no longer works
Summary: REGRESSION(r179477): arguments simplification no longer works
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-02 13:56 PST by Filip Pizlo
Modified: 2015-02-02 15:36 PST (History)
0 users

See Also:

Attachments
the patch (2.82 KB, patch)
2015-02-02 14:01 PST, Filip Pizlo 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-02-02 13:56:24 PST 
That change broke arguments simplification because PhantomLocal on the arguments register tells arguments simplification that it can't simplify anything.  PhantomLocal also confuses the Flush strength reduction and we were also missing some other cases there.  This resolves all of those issues.
Comment 1 Filip Pizlo 2015-02-02 14:01:47 PST 
Created attachment 245898 [details]
the patch
Comment 2 Mark Lam 2015-02-02 14:14:37 PST 
Comment on attachment 245898 [details]
the patch

You added a CPS rethreading phase.  Have you run perf numbers to make sure that there's no regression?

r=me if no perf regression.
Comment 3 Filip Pizlo 2015-02-02 15:34:35 PST 
(In reply to comment #2)
> Comment on attachment 245898 [details]
> the patch
> 
> You added a CPS rethreading phase.  Have you run perf numbers to make sure
> that there's no regression?
> 
> r=me if no perf regression.

Performance is good.  This is a progression on earley and no significant changes elsewhere.
Comment 4 Filip Pizlo 2015-02-02 15:36:56 PST 
Landed in http://trac.webkit.org/changeset/179504