Bug 141167 - Restore interface before exiting optimized fullscreen mode.
Summary: Restore interface before exiting optimized fullscreen mode.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-02 12:15 PST by Jeremy Jones
Modified: 2015-02-03 15:45 PST (History)
2 users (show)

See Also:

Attachments
Patch (3.93 KB, patch)
2015-02-02 12:25 PST, Jeremy Jones 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2015-02-02 12:15:59 PST 
Restore interface before exiting optimized fullscreen mode.
Comment 1 Jeremy Jones 2015-02-02 12:25:33 PST 
Created attachment 245893 [details]
Patch
Comment 2 Simon Fraser (smfr) 2015-02-03 15:32:32 PST 
Comment on attachment 245893 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245893&action=review

> Source/WebCore/platform/spi/ios/AVKitSPI.h:77
> +- (void)playerViewController:(AVPlayerViewController *)playerViewController restoreUserInterfaceForOptimizedFullscreeStopWithCompletionHandler:(void (^)(BOOL restored))completionHandler;

restoreUserInterfaceForOptimizedFullscree*n*StopWithCompletionHandler?

I think this would be much nicer as some kind of "did exit fullscreen" with some flags.
Comment 3 WebKit Commit Bot 2015-02-03 15:45:36 PST 
Comment on attachment 245893 [details]
Patch

Clearing flags on attachment: 245893

Committed r179575: <http://trac.webkit.org/changeset/179575>
Comment 4 WebKit Commit Bot 2015-02-03 15:45:39 PST 
All reviewed patches have been landed.  Closing bug.