Bug 141150 - [EFL] Add baselines for two region tests
Summary: [EFL] Add baselines for two region tests
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-02 03:20 PST by Kamil Nować
Modified: 2017-03-11 10:33 PST (History)
3 users (show)

See Also:

Attachments
Patch (6.45 KB, patch)
2015-02-02 03:42 PST, Kamil Nować 		no flags Details | Formatted Diff | Diff
Patch (4.70 KB, patch)
2015-02-02 06:54 PST, Kamil Nować 		no flags Details | Formatted Diff | Diff
Patch (4.52 KB, patch)
2015-02-02 07:45 PST, Kamil Nować 		gyuyoung.kim: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kamil Nować 2015-02-02 03:20:02 PST 
Added some tests marked as Missing.

* platform/efl/TestExpectations:
* platform/efl/fast/regions/repaint/region-painting-invalidation-expected.png: Added.
* platform/efl/fast/regions/repaint/region-painting-invalidation-expected.txt: Added.
* platform/efl/fast/regions/repaint/region-painting-via-layout-expected.png: Added.
* platform/efl/fast/regions/repaint/region-painting-via-layout-expected.txt: Added.
Comment 1 Kamil Nować 2015-02-02 03:42:08 PST 
Created attachment 245866 [details]
Patch
Comment 2 Kamil Nować 2015-02-02 06:54:44 PST 
Created attachment 245873 [details]
Patch
Comment 3 Krzysztof Czech 2015-02-02 07:01:33 PST 
Comment on attachment 245873 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245873&action=review

> LayoutTests/ChangeLog:3
> +        [EFL] Unreviewed EFL port gardening.

This title should be exactly the same as bug's title. Now it's different

> LayoutTests/ChangeLog:6
> +        Added some tests marked as Missing.

Seems you are adding new expectations rather than tests.
Comment 4 Kamil Nować 2015-02-02 07:45:32 PST 
Created attachment 245874 [details]
Patch
Comment 5 Kamil Nować 2015-02-02 07:47:24 PST 
Change expectations for two region tests.

* platform/efl/TestExpectations:
* platform/efl/fast/regions/repaint/region-painting-invalidation-expected.txt: Added.
* platform/efl/fast/regions/repaint/region-painting-via-layout-expected.txt: Added.
Comment 6 Krzysztof Czech 2015-02-02 07:52:41 PST 
Comment on attachment 245874 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245874&action=review

> LayoutTests/ChangeLog:6
> +        Change expectations for two region tests.

Just one thing, could add the exact revision where those two tests were added.
Would be easier to find those tests if needed.
Comment 7 Gyuyoung Kim 2015-02-03 07:56:35 PST 
Comment on attachment 245874 [details]
Patch

Set r+ed to land after fixing Krzysztof's comment.
Comment 8 Michael Catanzaro 2017-03-11 10:33:26 PST 
Closing this bug because the EFL port has been removed from trunk.

If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.