Bug 141135 - Clean up WebInspectorProxy and use simpler inspector levels design
Summary: Clean up WebInspectorProxy and use simpler inspector levels design
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brian Burg
URL:
Keywords:
Depends on: 141037
Blocks:
  Show dependency tree / graph
 
Reported: 2015-02-01 00:10 PST by Brian Burg
Modified: 2015-02-05 13:52 PST (History)
7 users (show)

See Also:

Attachments
Proposed Fix (42.46 KB, patch)
2015-02-01 00:25 PST, Brian Burg 		no flags Details | Formatted Diff | Diff
Patch for EWS (41.65 KB, patch)
2015-02-02 22:06 PST, Brian Burg 		no flags Details | Formatted Diff | Diff
Rebased Patch (42.69 KB, patch)
2015-02-03 15:44 PST, Brian Burg 		no flags Details | Formatted Diff | Diff
Rebased Patch (42.90 KB, patch)
2015-02-03 21:05 PST, Brian Burg 		no flags Details | Formatted Diff | Diff
Patch (fix iOS) (42.46 KB, patch)
2015-02-04 09:37 PST, Brian Burg 		timothy: review+
Details | Formatted Diff | Diff
Fix GTK,EFL (44.35 KB, patch)
2015-02-05 08:51 PST, Brian Burg 		no flags Details | Formatted Diff | Diff
Fix GTK (44.56 KB, patch)
2015-02-05 09:07 PST, Brian Burg 		no flags Details | Formatted Diff | Diff
Fix GTK (44.60 KB, patch)
2015-02-05 13:10 PST, Brian Burg 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2015-02-01 00:10:48 PST 
Patch forthcoming.
Comment 1 Brian Burg 2015-02-01 00:25:50 PST 
Created attachment 245824 [details]
Proposed Fix

Patch is rebased on top of conversion to WKWebView, so will reupload when ready.
Comment 2 Brian Burg 2015-02-02 22:06:45 PST 
Created attachment 245925 [details]
Patch for EWS
Comment 3 Brian Burg 2015-02-03 15:44:45 PST 
Created attachment 245980 [details]
Rebased Patch
Comment 4 Brian Burg 2015-02-03 21:05:26 PST 
Created attachment 246013 [details]
Rebased Patch
Comment 5 Brian Burg 2015-02-04 09:37:32 PST 
Created attachment 246036 [details]
Patch (fix iOS)
Comment 6 Timothy Hatcher 2015-02-04 14:11:21 PST 
Comment on attachment 246036 [details]
Patch (fix iOS)

Looks good. Just a couple of page() -> inspectorPage() changes in EFL and Gtk you missed.
Comment 7 Brian Burg 2015-02-05 08:51:56 PST 
Created attachment 246103 [details]
Fix GTK,EFL
Comment 8 Brian Burg 2015-02-05 09:07:08 PST 
Created attachment 246105 [details]
Fix GTK
Comment 9 Brian Burg 2015-02-05 13:10:50 PST 
Created attachment 246126 [details]
Fix GTK
Comment 10 Brian Burg 2015-02-05 13:52:15 PST 
Committed r179705: <http://trac.webkit.org/changeset/179705>