RESOLVED FIXED 141135
Clean up WebInspectorProxy and use simpler inspector levels design
https://bugs.webkit.org/show_bug.cgi?id=141135
Summary Clean up WebInspectorProxy and use simpler inspector levels design
Brian Burg
Reported 2015-02-01 00:10:48 PST
Patch forthcoming.
Attachments
Proposed Fix (42.46 KB, patch)
2015-02-01 00:25 PST, Brian Burg
no flags
Patch for EWS (41.65 KB, patch)
2015-02-02 22:06 PST, Brian Burg
no flags
Rebased Patch (42.69 KB, patch)
2015-02-03 15:44 PST, Brian Burg
no flags
Rebased Patch (42.90 KB, patch)
2015-02-03 21:05 PST, Brian Burg
no flags
Patch (fix iOS) (42.46 KB, patch)
2015-02-04 09:37 PST, Brian Burg
timothy: review+
Fix GTK,EFL (44.35 KB, patch)
2015-02-05 08:51 PST, Brian Burg
no flags
Fix GTK (44.56 KB, patch)
2015-02-05 09:07 PST, Brian Burg
no flags
Fix GTK (44.60 KB, patch)
2015-02-05 13:10 PST, Brian Burg
no flags
Brian Burg
Comment 1 2015-02-01 00:25:50 PST
Created attachment 245824 [details] Proposed Fix Patch is rebased on top of conversion to WKWebView, so will reupload when ready.
Brian Burg
Comment 2 2015-02-02 22:06:45 PST
Created attachment 245925 [details] Patch for EWS
Brian Burg
Comment 3 2015-02-03 15:44:45 PST
Created attachment 245980 [details] Rebased Patch
Brian Burg
Comment 4 2015-02-03 21:05:26 PST
Created attachment 246013 [details] Rebased Patch
Brian Burg
Comment 5 2015-02-04 09:37:32 PST
Created attachment 246036 [details] Patch (fix iOS)
Timothy Hatcher
Comment 6 2015-02-04 14:11:21 PST
Comment on attachment 246036 [details] Patch (fix iOS) Looks good. Just a couple of page() -> inspectorPage() changes in EFL and Gtk you missed.
Brian Burg
Comment 7 2015-02-05 08:51:56 PST
Created attachment 246103 [details] Fix GTK,EFL
Brian Burg
Comment 8 2015-02-05 09:07:08 PST
Brian Burg
Comment 9 2015-02-05 13:10:50 PST
Brian Burg
Comment 10 2015-02-05 13:52:15 PST
Note You need to log in before you can comment on or make changes to this bug.