Access MemoryCache singleton using MemoryCache::singleton() static member function, instead of a free function, as per the recent coding style discussion on WebKit-dev.
Created attachment 245757 [details] Patch
The win-ews does not seem to give a compilation error. Not sure why it failed.
ping review?
Comment on attachment 245757 [details] Patch r=me
Comment on attachment 245757 [details] Patch Clearing flags on attachment: 245757 Committed r179489: <http://trac.webkit.org/changeset/179489>
All reviewed patches have been landed. Closing bug.
This broke the Windows build, as was reported in <https://webkit-queues.appspot.com/results/5739814385090560> two days ago (at the same time as the other EWS bots reported their status). Fix landed in <http://trac.webkit.org/changeset/179498>.
(In reply to comment #7) > This broke the Windows build, as was reported in > <https://webkit-queues.appspot.com/results/5739814385090560> two days ago > (at the same time as the other EWS bots reported their status). > > Fix landed in <http://trac.webkit.org/changeset/179498>. Sorry Brent. I fails to see the missing symbol error in the output and thus did not understand why the win-ews was failing. BTW, I don't know if we can do something about this I always have trouble finding the build errors on the win-ews stdio. Most bots would give out the errors at the end but win-ews doesn't. I usually search for "error C" on win-ews, but this apparently only works for build errors, not linking ones.
(In reply to comment #8) > (In reply to comment #7) > > This broke the Windows build, as was reported in > > <https://webkit-queues.appspot.com/results/5739814385090560> two days ago > > (at the same time as the other EWS bots reported their status). > > > > Fix landed in <http://trac.webkit.org/changeset/179498>. > > Sorry Brent. I fails to see the missing symbol error in the output and thus > did not understand why the win-ews was failing. BTW, I don't know if we can > do something about this I always have trouble finding the build errors on > the win-ews stdio. Most bots would give out the errors at the end but > win-ews doesn't. I usually search for "error C" on win-ews, but this > apparently only works for build errors, not linking ones. Yes -- I think these show up as "error LNK0123", so I search for "error L" if I don't find something under "error C". Darin has encountered a case where neither error is shown in the EWS log because of the massive amounts of output produced. We have a filtering script that is used on our internal bots, but it hasn't been migrated to the OpenSource or EWS bots for reasons that I don't fully understand.
(In reply to comment #9) > (In reply to comment #8) > > (In reply to comment #7) > > > This broke the Windows build, as was reported in > > > <https://webkit-queues.appspot.com/results/5739814385090560> two days ago > > > (at the same time as the other EWS bots reported their status). > > > > > > Fix landed in <http://trac.webkit.org/changeset/179498>. > > > > Sorry Brent. I fails to see the missing symbol error in the output and thus > > did not understand why the win-ews was failing. BTW, I don't know if we can > > do something about this I always have trouble finding the build errors on > > the win-ews stdio. Most bots would give out the errors at the end but > > win-ews doesn't. I usually search for "error C" on win-ews, but this > > apparently only works for build errors, not linking ones. > > Yes -- I think these show up as "error LNK0123", so I search for "error L" > if I don't find something under "error C". Good to know the "error L" one. I'll do this next time if "error C" doesn't work. Thanks. BTW, if the windows-ews is reliable enough these days, we could probably make the commit queue depend on it succeeding to build. Currently, I think the CQ stops only if mac-ews fails.