by making members private.
Created attachment 245729 [details] Patch
Comment on attachment 245729 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245729&action=review Nice :) r=me > Source/WebCore/rendering/SimpleLineLayoutFlowContentsIterator.h:66 > + unsigned m_end { 0 }; Might as well fix the double space before { here.
Created attachment 245770 [details] Patch
Created attachment 245771 [details] Patch
Comment on attachment 245771 [details] Patch Clearing flags on attachment: 245771 Committed r179438: <http://trac.webkit.org/changeset/179438>
All reviewed patches have been landed. Closing bug.
This caused a crash (assertion failure): https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK1%20(Tests)/r179440%20(1938)/fast/forms/basic-textareas-simple-lines-crash-log.txt Alan, Andreas, do you happen to be available to investigate soon?
(In reply to comment #7) > This caused a crash (assertion failure): > https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK1%20(Tests)/ > r179440%20(1938)/fast/forms/basic-textareas-simple-lines-crash-log.txt > > Alan, Andreas, do you happen to be available to investigate soon? Thanks. Looking at it now.
(In reply to comment #7) > This caused a crash (assertion failure): > https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK1%20(Tests)/ > r179440%20(1938)/fast/forms/basic-textareas-simple-lines-crash-log.txt > > Alan, Andreas, do you happen to be available to investigate soon? Bug 141121