RESOLVED FIXED141090
Simple line layout: Improve FlowContentsIterator::TextFragment's encapsulation. 
https://bugs.webkit.org/show_bug.cgi?id=141090
Summary Simple line layout: Improve FlowContentsIterator::TextFragment's encapsulation.
alan
Reported 2015-01-30 11:41:43 PST
by making members private.
Attachments
Patch (17.30 KB, patch)
2015-01-30 11:48 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (18.50 KB, patch)
2015-01-30 20:57 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (18.49 KB, patch)
2015-01-30 21:41 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2015-01-30 11:48:27 PST
Created attachment 245729 [details] Patch
Andreas Kling
Comment 2 2015-01-30 18:50:16 PST
Comment on attachment 245729 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245729&action=review Nice :) r=me > Source/WebCore/rendering/SimpleLineLayoutFlowContentsIterator.h:66 > + unsigned m_end { 0 }; Might as well fix the double space before { here.
alan
Comment 3 2015-01-30 20:57:26 PST
Created attachment 245770 [details] Patch
alan
Comment 4 2015-01-30 21:41:30 PST
Created attachment 245771 [details] Patch
WebKit Commit Bot
Comment 5 2015-01-30 22:26:00 PST
Comment on attachment 245771 [details] Patch Clearing flags on attachment: 245771 Committed r179438: <http://trac.webkit.org/changeset/179438>
WebKit Commit Bot
Comment 6 2015-01-30 22:26:03 PST
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 7 2015-01-31 09:53:26 PST
This caused a crash (assertion failure): https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK1%20(Tests)/r179440%20(1938)/fast/forms/basic-textareas-simple-lines-crash-log.txt Alan, Andreas, do you happen to be available to investigate soon?
alan
Comment 8 2015-01-31 09:58:42 PST
(In reply to comment #7) > This caused a crash (assertion failure): > https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK1%20(Tests)/ > r179440%20(1938)/fast/forms/basic-textareas-simple-lines-crash-log.txt > > Alan, Andreas, do you happen to be available to investigate soon? Thanks. Looking at it now.
alan
Comment 9 2015-01-31 11:30:31 PST
(In reply to comment #7) > This caused a crash (assertion failure): > https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK1%20(Tests)/ > r179440%20(1938)/fast/forms/basic-textareas-simple-lines-crash-log.txt > > Alan, Andreas, do you happen to be available to investigate soon? Bug 141121
Note You need to log in before you can comment on or make changes to this bug.