Bug 141090 - Simple line layout: Improve FlowContentsIterator::TextFragment's encapsulation.
Summary: Simple line layout: Improve FlowContentsIterator::TextFragment's encapsulation.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-30 11:41 PST by zalan
Modified: 2015-01-31 11:30 PST (History)
7 users (show)

See Also:

Attachments
Patch (17.30 KB, patch)
2015-01-30 11:48 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (18.50 KB, patch)
2015-01-30 20:57 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (18.49 KB, patch)
2015-01-30 21:41 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2015-01-30 11:41:43 PST 
by making members private.
Comment 1 zalan 2015-01-30 11:48:27 PST 
Created attachment 245729 [details]
Patch
Comment 2 Andreas Kling 2015-01-30 18:50:16 PST 
Comment on attachment 245729 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245729&action=review

Nice :) r=me

> Source/WebCore/rendering/SimpleLineLayoutFlowContentsIterator.h:66
> +        unsigned m_end  { 0 };

Might as well fix the double space before { here.
Comment 3 zalan 2015-01-30 20:57:26 PST 
Created attachment 245770 [details]
Patch
Comment 4 zalan 2015-01-30 21:41:30 PST 
Created attachment 245771 [details]
Patch
Comment 5 WebKit Commit Bot 2015-01-30 22:26:00 PST 
Comment on attachment 245771 [details]
Patch

Clearing flags on attachment: 245771

Committed r179438: <http://trac.webkit.org/changeset/179438>
Comment 6 WebKit Commit Bot 2015-01-30 22:26:03 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Alexey Proskuryakov 2015-01-31 09:53:26 PST 
This caused a crash (assertion failure): https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK1%20(Tests)/r179440%20(1938)/fast/forms/basic-textareas-simple-lines-crash-log.txt

Alan, Andreas, do you happen to be available to investigate soon?
Comment 8 zalan 2015-01-31 09:58:42 PST 
(In reply to comment #7)
> This caused a crash (assertion failure):
> https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK1%20(Tests)/
> r179440%20(1938)/fast/forms/basic-textareas-simple-lines-crash-log.txt
> 
> Alan, Andreas, do you happen to be available to investigate soon?

Thanks. Looking at it now.
Comment 9 zalan 2015-01-31 11:30:31 PST 
(In reply to comment #7)
> This caused a crash (assertion failure):
> https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK1%20(Tests)/
> r179440%20(1938)/fast/forms/basic-textareas-simple-lines-crash-log.txt
> 
> Alan, Andreas, do you happen to be available to investigate soon?

Bug 141121