Bug 141078 - vprintf_stderr_common print garbage bytes in windows
Summary: vprintf_stderr_common print garbage bytes in windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-30 05:21 PST by Namhoon Kim
Modified: 2015-01-30 16:39 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.39 KB, patch)
2015-01-30 05:30 PST, Namhoon Kim 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Namhoon Kim 2015-01-30 05:21:55 PST 
https://bugs.webkit.org/show_bug.cgi?id=140917#c6

If formatted string made in vprintf_stderr_common has length of exactly 1024, windows api _vsnprintf does not place null character automatically. It makes following OutputDebugStringA call prints some garbage bytes.

I don't think it's a critical bug. Because vprintf_stderr_common function does not used anywhere.
Comment 1 Namhoon Kim 2015-01-30 05:30:57 PST 
Created attachment 245712 [details]
Patch
Comment 2 Brent Fulgham 2015-01-30 10:47:54 PST 
Comment on attachment 245712 [details]
Patch

R=me. Thank you!
Comment 3 WebKit Commit Bot 2015-01-30 16:39:38 PST 
Comment on attachment 245712 [details]
Patch

Clearing flags on attachment: 245712

Committed r179424: <http://trac.webkit.org/changeset/179424>
Comment 4 WebKit Commit Bot 2015-01-30 16:39:42 PST 
All reviewed patches have been landed.  Closing bug.