Bug 141076 - [cairo] Fix #if guards in platform/graphics/cairo directory
Summary: [cairo] Fix #if guards in platform/graphics/cairo directory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-30 03:25 PST by Csaba Osztrogonác
Modified: 2015-01-30 05:57 PST (History)
3 users (show)

See Also:


Attachments
Patch (22.28 KB, patch)
2015-01-30 03:27 PST, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff
Patch (22.29 KB, patch)
2015-01-30 03:54 PST, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-01-30 03:25:41 PST
problems in nutshell:
- missing USE(CAIRO) guards
- guards in wrong place
- missing comments for namespace end and #endif
- ...
Comment 1 Csaba Osztrogonác 2015-01-30 03:27:03 PST
Created attachment 245707 [details]
Patch
Comment 2 Csaba Osztrogonác 2015-01-30 03:54:28 PST
Created attachment 245708 [details]
Patch

typo fixed in OwnPtrCairo.h
Comment 3 Sergio Villar Senin 2015-01-30 05:43:22 PST
Comment on attachment 245708 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245708&action=review

Really. Nice. Stuff.

> Source/WebCore/platform/graphics/cairo/TransformationMatrixCairo.cpp:-66
> -// vim: ts=4 sw=4 et

:O
Comment 4 Csaba Osztrogonác 2015-01-30 05:56:55 PST
Comment on attachment 245708 [details]
Patch

Clearing flags on attachment: 245708

Committed r179398: <http://trac.webkit.org/changeset/179398>
Comment 5 Csaba Osztrogonác 2015-01-30 05:57:02 PST
All reviewed patches have been landed.  Closing bug.