Bug 141069 – Optimize MemoryCache::getSessionMap() a bit

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Chris Dumez]

Optimize MemoryCache::getSessionMap() a bit

[Chris Dumez]

Created attachment 245696 [details]
Patch

[Anders Carlsson]

Comment on attachment 245696 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245696&action=review

> Source/WebCore/loader/cache/MemoryCache.cpp:80
> +    std::unique_ptr<CachedResourceMap>& map = m_sessionResources.add(sessionID, nullptr).iterator->value;

auto& map =

> Source/WebCore/loader/cache/MemoryCache.h:187
> -    CachedResourceMap& getSessionMap(SessionID);
> +    CachedResourceMap& sessionResources(SessionID = SessionID::defaultSessionID());

I think it's better to be explicit about which session we want here, otherwise it's easy to always use the default session.

[Chris Dumez]

Committed r179403: <http://trac.webkit.org/changeset/179403>

[Alexey Proskuryakov]

This caused a crash:

https://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK1%20(Tests)/r179403%20(10178)/fast/files/workers/worker-apply-blob-url-to-xhr-crash-log.txt

[WebKit Commit Bot]

Re-opened since this is blocked by bug 141091

[Chris Dumez]

Rolled out in <http://trac.webkit.org/changeset/179410>. I'll propose another fix.

[Chris Dumez]

Created attachment 245746 [details]
Patch

[Chris Dumez]

New version of the patch will no longer causes any assertion hit in HashTable code.

[Chris Dumez]

Created attachment 245752 [details]
Patch

[Chris Dumez]

Created attachment 245759 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 245759 [details]
Patch

Clearing flags on attachment: 245759

Committed r179431: <http://trac.webkit.org/changeset/179431>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.