Bug 141064 – Web Inspector: Extend CSS.getSupportedCSSProperties to provide values for properties for CSS Augmented JSContext

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
For a CSS Augmented JSContext it can provide custom CSS properties via CSS.getSupportedCSSProperties. If that is the case, they can provide custom autocompletion values.

[Joseph Pecoraro]

<rdar://problem/19640303>

[Joseph Pecoraro]

Created attachment 245682 [details]
[PATCH] Proposed Fix

[Timothy Hatcher]

Comment on attachment 245682 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=245682&action=review

> Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js:94
> +    WebInspector.CSSKeywordCompletions._propertyKeywordMap[propertyName] = [...union.values()];

[...existingValues, ...newValues]?

[Joseph Pecoraro]

(In reply to comment #3)
> Comment on attachment 245682 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=245682&action=review
> 
> > Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js:94
> > +    WebInspector.CSSKeywordCompletions._propertyKeywordMap[propertyName] = [...union.values()];
> 
> [...existingValues, ...newValues]?

I wanted to avoid duplicates in the list if possible.

[WebKit Commit Bot]

Comment on attachment 245682 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 245682

Committed r179483: <http://trac.webkit.org/changeset/179483>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.