Bug 141064 - Web Inspector: Extend CSS.getSupportedCSSProperties to provide values for properties for CSS Augmented JSContext
Summary: Web Inspector: Extend CSS.getSupportedCSSProperties to provide values for pro...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2015-01-29 18:36 PST by Joseph Pecoraro
Modified: 2015-02-02 12:07 PST (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (5.04 KB, patch)
2015-01-29 18:51 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-01-29 18:36:46 PST 
* SUMMARY
For a CSS Augmented JSContext it can provide custom CSS properties via CSS.getSupportedCSSProperties. If that is the case, they can provide custom autocompletion values.
Comment 1 Joseph Pecoraro 2015-01-29 18:37:10 PST 
<rdar://problem/19640303>
Comment 2 Joseph Pecoraro 2015-01-29 18:51:54 PST 
Created attachment 245682 [details]
[PATCH] Proposed Fix
Comment 3 Timothy Hatcher 2015-01-30 04:51:49 PST 
Comment on attachment 245682 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=245682&action=review

> Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js:94
> +    WebInspector.CSSKeywordCompletions._propertyKeywordMap[propertyName] = [...union.values()];

[...existingValues, ...newValues]?
Comment 4 Joseph Pecoraro 2015-02-02 11:21:58 PST 
(In reply to comment #3)
> Comment on attachment 245682 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=245682&action=review
> 
> > Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js:94
> > +    WebInspector.CSSKeywordCompletions._propertyKeywordMap[propertyName] = [...union.values()];
> 
> [...existingValues, ...newValues]?

I wanted to avoid duplicates in the list if possible.
Comment 5 WebKit Commit Bot 2015-02-02 12:06:58 PST 
Comment on attachment 245682 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 245682

Committed r179483: <http://trac.webkit.org/changeset/179483>
Comment 6 WebKit Commit Bot 2015-02-02 12:07:01 PST 
All reviewed patches have been landed.  Closing bug.