Bug 141061 - Remote Web Inspector should not show undock toolbar buttons
Summary: Remote Web Inspector should not show undock toolbar buttons
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-01-29 17:16 PST by Joseph Pecoraro
Modified: 2015-01-30 15:56 PST (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.41 KB, patch)
2015-01-29 17:26 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-01-29 17:16:55 PST 
* SUMMARY
Remote Web Inspector should not show undock toolbar buttons.

* STEPS TO REPRODUCE
1. Remote Inspect iOS 8 MobileSafari or JSContext
  => frontend has undock buttons
Comment 1 Radar WebKit Bug Importer 2015-01-29 17:17:12 PST 
<rdar://problem/19656961>
Comment 2 Joseph Pecoraro 2015-01-29 17:24:31 PST 
Looks like this broke with:
https://trac.webkit.org/changeset/173929

That removed:

    // Update the docked state based on the query string passed when the Web Inspector was loaded.
    this.updateDockedState(parseLocationQueryParameters().dockSide || "undocked");


Which caused the buttons to never update as "undocked" and therefore hidden. Easy fix.
Comment 3 Joseph Pecoraro 2015-01-29 17:26:31 PST 
Created attachment 245675 [details]
[PATCH] Proposed Fix
Comment 4 Timothy Hatcher 2015-01-30 04:54:56 PST 
Comment on attachment 245675 [details]
[PATCH] Proposed Fix

Oops! Thanks!
Comment 5 WebKit Commit Bot 2015-01-30 15:56:42 PST 
Comment on attachment 245675 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 245675

Committed r179418: <http://trac.webkit.org/changeset/179418>
Comment 6 WebKit Commit Bot 2015-01-30 15:56:46 PST 
All reviewed patches have been landed.  Closing bug.