Bug 141060 – [Win] Switch to Apache on Windows

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Brent Fulgham]

We have not had good results using Cygwin apache or lighttpd as our testing infrastructure. Instead, let's use a native Windows build of Apache so that we can turn SSL tests and other things back on.

[Brent Fulgham]

Created attachment 245691 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 245691 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245691&action=review

> Tools/Scripts/webkitpy/port/win.py:116
>      # Note: These are based on the stock Cygwin locations for these files.

Is this comment still helpful?

> LayoutTests/http/conf/apache2.4-httpd-win.conf:16
> +#MinSpareServers 1
> +#MaxSpareServers 5
> +#StartServers 1
> +#MaxRequestWorkers 150
> +#MaxConnectionsPerChild 100000

Are any of the commented out lines helpful enough to keep them? I'd delete everything that is commented out in this file.

> LayoutTests/http/conf/apache2.4-httpd-win.conf:68
> +ErrorLog "C:\xampp\apache\logs\error_log.txt"

We need to put this log into test directory to upload with test results (as well as access_log).

> LayoutTests/http/conf/apache2.4-httpd-win.conf:129
> +    AddType text/html .shtml
> +    AddHandler server-parsed .shtml

Do we really have any of these in tests? Do other platforms enable the handler?

> LayoutTests/http/conf/apache2.4-httpd-win.conf:185
> +#
> +# Apple-specific filesystem protection.
> +#
> +<Files "rsrc">
> +    Order allow,deny
> +    Deny from all
> +    Satisfy All
> +</Files>
> +
> +<Directory  ~ ".*\.\.namedfork">
> +    Order allow,deny
> +    Deny from all
> +    Satisfy All
> +</Directory>

This can all be removed.

[Brent Fulgham]

Comment on attachment 245691 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245691&action=review

Thank you for the review!

>> LayoutTests/http/conf/apache2.4-httpd-win.conf:16
>> +#MaxConnectionsPerChild 100000
> 
> Are any of the commented out lines helpful enough to keep them? I'd delete everything that is commented out in this file.

Good point. I'll remove them.

>> LayoutTests/http/conf/apache2.4-httpd-win.conf:68
>> +ErrorLog "C:\xampp\apache\logs\error_log.txt"
> 
> We need to put this log into test directory to upload with test results (as well as access_log).

This is controlled at runtime by the command line arguments we use when launching httpd. This is just the "stock" location from the original config file. I'd prefer to use environment variables to point to the users WebKit directory, but unfortunately there is no way (that I know of) to do so in an Apache config file.

>> LayoutTests/http/conf/apache2.4-httpd-win.conf:129
>> +    AddHandler server-parsed .shtml
> 
> Do we really have any of these in tests? Do other platforms enable the handler?

This was in the original WebKit apache2.4-httpd.conf file, so I assumed it was needed. Yes, the other platforms do enable this (or at least, have it in the configuration file)

>> LayoutTests/http/conf/apache2.4-httpd-win.conf:185
>> +</Directory>
> 
> This can all be removed.

Done!

[Brent Fulgham]

Committed r179405: <http://trac.webkit.org/changeset/179405>