Bug 141059 – When no background-size is specified on the 2nd background layer, it takes the first instead of the initial value

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Lea Verou]

Check testcase.

Testcase works everywhere else, fails on WebKit nightlies (as well as Safari, Mobile Safari etc).

[Chris Dumez]

(In reply to comment #0)
> Check testcase.
> 
> Testcase works everywhere else, fails on WebKit nightlies (as well as
> Safari, Mobile Safari etc).

Thanks for the bug report and the test case. I am looking into it now.

[Chris Dumez]

Created attachment 245693 [details]
Patch

[Antti Koivisto]

Comment on attachment 245693 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245693&action=review

> LayoutTests/fast/css/background-layers-initial-size.html:22
> +// The second layer should have "auto" as background size as it is its initial value.
> +shouldBeEqualToString("computedBackgroundSize", "25px 25px, auto");

Doesn't window.getComputedStyle generally try to resolve auto values and not return them as 'auto'?

[Antti Koivisto]

What does Firefox return here?

[Chris Dumez]

(In reply to comment #4)
> What does Firefox return here?

Firefox shows "25px 25px, auto auto". Chrome shows "25px 25px, auto".

[Chris Dumez]

(In reply to comment #5)
> (In reply to comment #4)
> > What does Firefox return here?
> 
> Firefox shows "25px 25px, auto auto". Chrome shows "25px 25px, auto".

Our previous output was "25px 25px, 25px 25px", which was obviously bad.

[Antti Koivisto]

Comment on attachment 245693 [details]
Patch

ok

[Chris Dumez]

Comment on attachment 245693 [details]
Patch

Clearing flags on attachment: 245693

Committed r179413: <http://trac.webkit.org/changeset/179413>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.

[Lea Verou]

Impressive. Reported and fixed in less than 24 hours!! Thanks everyone!