Bug 141058 – Web Inspector: Support console.table

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
Support console.table:
https://developer.mozilla.org/en-US/docs/Web/API/Console.table

* SUGGESTED OUTPUT
- Support a single array:
  - console.table(["a", "b", "c"])
  => 2 columns, "Index" and "Value"
- Support a single object: 
  - console.table({first:"Joe",last:"Peck"})
  => 2 columns, "Index" which will be object keys and "Value" the value for that key
- Support array of arrays: console.table([["Joe", "Peck"], ["First", "Last"]])
  => 3 columns, "(Index)" for the item index in the outer list, "0", "1" indexes of the arrays in the inner lists
- Support array of objects: console.table({first:"Joe",last:"Peck"}, {first:"First",last:"Last"})
  => 3 columns, "(Index)" for the item index in the outer list, "first", "last" properties of the objects in the inner list
- Support column name filtering optional second argument:
  - console.table({first:"Joe",last:"Peck"}, {first:"First",last:"Last"}, ["first"])
  - console.table({first:"Joe",last:"Peck"}, {first:"First",last:"Last"}, "first")
  => 2 columns, "(Index)" for the item index in the outer list, "first" the property of the objects in the inner list
- Only support 10 properties / array indexes + the "(Index)" column
  - console.table([arrWith20Values, arrWith20Values])
  => 11 columns, "(Index)" for the item index in the outer list, "0".."9" for the indexes of the arrays

* NOTES
- One major advantage of console.table is being able to sort the output, so support sorting!

[Radar WebKit Bug Importer]

<rdar://problem/19655635>

[Joseph Pecoraro]

NOTE: Blink added a Command Line API shortcut "table" for "console.table"
<http://code.google.com/p/chromium/issues/detail?id=168776>

[Joseph Pecoraro]

<rdar://problem/13671069>

[Joseph Pecoraro]

Created attachment 245668 [details]
[IMAGE] Progress

This is what I have so far. Selection is a bit wonky. But it works pretty well! I need to add tests before putting up a patch.

[Joseph Pecoraro]

Created attachment 245670 [details]
[PATCH] Proposed Fix

Actually, tests here are not useful until we refactor ConsoleMessage logic into Model objects and View objects. Currently Test.js tests avoid Console tests for this, and testing at the inspector-protocol level is not particularly useful. We would just be testing that we get the "table". string...

[Build Bot]

Comment on attachment 245670 [details]
[PATCH] Proposed Fix

Attachment 245670 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4803867996848128

New failing tests:
http/tests/inspector-protocol/access-inspected-object.html

[Build Bot]

Created attachment 245674 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 245670 [details]
[PATCH] Proposed Fix

Attachment 245670 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5338354128257024

New failing tests:
http/tests/inspector-protocol/access-inspected-object.html

[Build Bot]

Created attachment 245677 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Joseph Pecoraro]

http://trac.webkit.org/changeset/179493

I might have to rebaseline that one test. I'll watch for it.