Bug 141038 – Remove support for screen font substitution

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

Remove support for screen font substitution

[Sam Weinig]

Created attachment 245628 [details]
Patch

[Build Bot]

Comment on attachment 245628 [details]
Patch

Attachment 245628 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5841498809565184

New failing tests:
fast/text/international/hindi-spacing.html

[Build Bot]

Created attachment 245630 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 245628 [details]
Patch

Attachment 245628 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5561114754547712

New failing tests:
fast/text/international/hindi-spacing.html

[Build Bot]

Created attachment 245633 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Sam Weinig]

Created attachment 245647 [details]
Patch

[Tim Horton]

Comment on attachment 245647 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245647&action=review

> Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm:290
> +    scaledFontData.setNSFont([scaledFontData.nsFont() printerFont]);

Is this still needed? Which direction does it reset in?

[Sam Weinig]

Committed r179368: <http://trac.webkit.org/changeset/179368>

[Tim Horton]

Build fix in http://trac.webkit.org/changeset/179370

[Csaba Osztrogonác]

The Windows build is still broken: 
     1>..\platform\graphics\win\UniscribeController.cpp(316): error C2039: 'isPrinterFont' : is not a member of 'WebCore::FontCascade'
                 C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform\graphics\FontCascade.h(109) : see declaration of 'WebCore::FontCascade'

[Alexey Proskuryakov]

Also, several tests and iOS build are still broken.

https://build.webkit.org/results/Apple%20Yosemite%20Release%20WK2%20(Tests)/r179372%20(2409)/results.html

https://webkit-queues.appspot.com/results/5149855261392896

Will roll out.

[Brent Fulgham]

Windows build fix in r179381 <https://trac.webkit.org/changeset/179381>
and r179383 <https://trac.webkit.org/changeset/179383>

[Chris Dumez]

The following test is still failing on the bots after this change:
fast/text/international/hindi-spacing.html

See:
https://build.webkit.
org/results/Apple%20Mavericks%20Release%20WK1%20(Tests)/r179368%20(11726)/results.html

[Chris Dumez]

(In reply to comment #13)
> The following test is still failing on the bots after this change:
> fast/text/international/hindi-spacing.html
> 
> See:
> https://build.webkit.
> org/results/Apple%20Mavericks%20Release%20WK1%20(Tests)/r179368%20(11726)/
> results.html

Actually, it looks like Sam rebaselined it in https://trac.webkit.org/changeset/179385. However, it seems fast/forms/select-visual-hebrew.html started failing after that rebaseline:
https://build.webkit.org/results/Apple%20Mavericks%20Release%20WK1%20(Tests)/r179392%20(11741)/results.html

[Chris Dumez]

(In reply to comment #14)
> (In reply to comment #13)
> > The following test is still failing on the bots after this change:
> > fast/text/international/hindi-spacing.html
> > 
> > See:
> > https://build.webkit.
> > org/results/Apple%20Mavericks%20Release%20WK1%20(Tests)/r179368%20(11726)/
> > results.html
> 
> Actually, it looks like Sam rebaselined it in
> https://trac.webkit.org/changeset/179385. However, it seems
> fast/forms/select-visual-hebrew.html started failing after that rebaseline:
> https://build.webkit.org/results/Apple%20Mavericks%20Release%20WK1%20(Tests)/
> r179392%20(11741)/results.html

I have just rebaselined it for mavericks in <http://trac.webkit.org/changeset/179394>.