Bug 141034 - [EFL] Gardening of failing tests
Summary: [EFL] Gardening of failing tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-29 08:00 PST by Dariusz Frankiewicz
Modified: 2015-01-30 16:40 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.39 KB, patch)
2015-01-29 08:18 PST, Dariusz Frankiewicz 		no flags Details | Formatted Diff | Diff
Patch (1.65 KB, patch)
2015-01-30 03:11 PST, Dariusz Frankiewicz 		no flags Details | Formatted Diff | Diff
patch (2.93 KB, patch)
2015-01-30 05:17 PST, Dariusz Frankiewicz 		no flags Details | Formatted Diff | Diff
patch (3.01 KB, patch)
2015-01-30 05:41 PST, Dariusz Frankiewicz 		no flags Details | Formatted Diff | Diff
Patch (3.24 KB, patch)
2015-01-30 06:14 PST, Dariusz Frankiewicz 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dariusz Frankiewicz 2015-01-29 08:00:40 PST 
The following layout tests are failing on EFL Linux 64-bit Release WK2:

accessibility/inline-block-assertion.html
accessibility/legend-children-are-visible.html
Comment 1 Dariusz Frankiewicz 2015-01-29 08:18:37 PST 
Created attachment 245622 [details]
Patch
Comment 2 Grzegorz Czajkowski 2015-01-29 23:59:43 PST 
Comment on attachment 245622 [details]
Patch

Added commit queue request
Comment 3 Dariusz Frankiewicz 2015-01-30 03:11:18 PST 
Created attachment 245706 [details]
Patch
Comment 4 Dariusz Frankiewicz 2015-01-30 03:13:14 PST 
Added all failing and misisng tests from accessibility to TestExpectations.
Comment 5 Dariusz Frankiewicz 2015-01-30 05:17:39 PST 
Created attachment 245710 [details]
patch

Added new expected results to accessibility/roles-exposed.html test.
Comment 6 Krzysztof Czech 2015-01-30 05:29:29 PST 
Comment on attachment 245710 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245710&action=review

> LayoutTests/ChangeLog:3
> +        [EFL] Gardening of failing tests

Maybe you could change to "Gardening: update some accessibility tests as failed"

> LayoutTests/ChangeLog:9
> +        * platform/efl/accessibility/roles-exposed-expected.txt:

would be nice whether you add some small description after the colon such as: update expectation after bumping ATK to 2.15.2
Comment 7 Dariusz Frankiewicz 2015-01-30 05:41:08 PST 
Created attachment 245714 [details]
patch

Done
Comment 8 Dariusz Frankiewicz 2015-01-30 06:14:42 PST 
Created attachment 245718 [details]
Patch
Comment 9 WebKit Commit Bot 2015-01-30 16:40:32 PST 
Comment on attachment 245718 [details]
Patch

Clearing flags on attachment: 245718

Committed r179425: <http://trac.webkit.org/changeset/179425>
Comment 10 WebKit Commit Bot 2015-01-30 16:40:36 PST 
All reviewed patches have been landed.  Closing bug.