Bug 141033 - Move HAVE_DTRACE definition back to Platform.h
Summary: Move HAVE_DTRACE definition back to Platform.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Blocker
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 141027
  Show dependency tree / graph
 
Reported: 2015-01-29 07:37 PST by Csaba Osztrogonác
Modified: 2015-01-29 09:07 PST (History)
6 users (show)

See Also:

Attachments
Patch (2.94 KB, patch)
2015-01-29 07:37 PST, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
Patch (4.11 KB, patch)
2015-01-29 07:47 PST, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-01-29 07:37:05 PST 
Move HAVE_DTRACE definition back to Platform.h
Comment 1 Csaba Osztrogonác 2015-01-29 07:37:17 PST 
Created attachment 245619 [details]
Patch
Comment 2 Csaba Osztrogonác 2015-01-29 07:38:14 PST 
It is a preparation for bug141027
Comment 3 Csaba Osztrogonác 2015-01-29 07:47:08 PST 
Created attachment 245620 [details]
Patch
Comment 4 mitz 2015-01-29 08:11:38 PST 
Comment on attachment 245620 [details]
Patch

dtrace is more of an OS(DARWIN) thing than a PLATFORM(COCOA) thing, I think.
Comment 5 Csaba Osztrogonác 2015-01-29 08:12:53 PST 
(In reply to comment #4)
> Comment on attachment 245620 [details]
> Patch
> 
> dtrace is more of an OS(DARWIN) thing than a PLATFORM(COCOA) thing, I think.

There is GTK on OS(DARWIN) and GTK maybe don't want to ship dtrace.
Comment 6 Csaba Osztrogonác 2015-01-29 08:15:28 PST 
Additionally it was defined for only Mac/iOS in xcconfig, 
I can't see the reason why should we change this behaviour.
Comment 7 Csaba Osztrogonác 2015-01-29 08:42:42 PST 
ping?
Comment 8 mitz 2015-01-29 08:50:41 PST 
Comment on attachment 245620 [details]
Patch

Seems reasonable. Someone else can update the JavaScriptCore project to use a native Xcode build rule for generating the header, now that it’s unconditional.
Comment 9 Csaba Osztrogonác 2015-01-29 08:57:24 PST 
Let's land it now as is, the xcode project file can be polished later.
Comment 10 Csaba Osztrogonác 2015-01-29 08:58:17 PST 
Comment on attachment 245620 [details]
Patch

Clearing flags on attachment: 245620

Committed r179345: <http://trac.webkit.org/changeset/179345>
Comment 11 Csaba Osztrogonác 2015-01-29 08:58:25 PST 
All reviewed patches have been landed.  Closing bug.
Comment 12 Csaba Osztrogonác 2015-01-29 09:07:12 PST 
new bug report for polishing: bug141036