RESOLVED FIXED 141033
Move HAVE_DTRACE definition back to Platform.h 
https://bugs.webkit.org/show_bug.cgi?id=141033
Summary Move HAVE_DTRACE definition back to Platform.h
Csaba Osztrogonác
Reported 2015-01-29 07:37:05 PST
Move HAVE_DTRACE definition back to Platform.h
Attachments
Patch (2.94 KB, patch)
2015-01-29 07:37 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch (4.11 KB, patch)
2015-01-29 07:47 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2015-01-29 07:37:17 PST
Created attachment 245619 [details] Patch
Csaba Osztrogonác
Comment 2 2015-01-29 07:38:14 PST
It is a preparation for bug141027
Csaba Osztrogonác
Comment 3 2015-01-29 07:47:08 PST
Created attachment 245620 [details] Patch
mitz
Comment 4 2015-01-29 08:11:38 PST
Comment on attachment 245620 [details] Patch dtrace is more of an OS(DARWIN) thing than a PLATFORM(COCOA) thing, I think.
Csaba Osztrogonác
Comment 5 2015-01-29 08:12:53 PST
(In reply to comment #4) > Comment on attachment 245620 [details] > Patch > > dtrace is more of an OS(DARWIN) thing than a PLATFORM(COCOA) thing, I think. There is GTK on OS(DARWIN) and GTK maybe don't want to ship dtrace.
Csaba Osztrogonác
Comment 6 2015-01-29 08:15:28 PST
Additionally it was defined for only Mac/iOS in xcconfig, I can't see the reason why should we change this behaviour.
Csaba Osztrogonác
Comment 7 2015-01-29 08:42:42 PST
ping?
mitz
Comment 8 2015-01-29 08:50:41 PST
Comment on attachment 245620 [details] Patch Seems reasonable. Someone else can update the JavaScriptCore project to use a native Xcode build rule for generating the header, now that it’s unconditional.
Csaba Osztrogonác
Comment 9 2015-01-29 08:57:24 PST
Let's land it now as is, the xcode project file can be polished later.
Csaba Osztrogonác
Comment 10 2015-01-29 08:58:17 PST
Comment on attachment 245620 [details] Patch Clearing flags on attachment: 245620 Committed r179345: <http://trac.webkit.org/changeset/179345>
Csaba Osztrogonác
Comment 11 2015-01-29 08:58:25 PST
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 12 2015-01-29 09:07:12 PST
new bug report for polishing: bug141036
Note You need to log in before you can comment on or make changes to this bug.