Bug 141024 - Rename 'usesArguments' to 'setUsesArguments' in ASTBuilder
Summary: Rename 'usesArguments' to 'setUsesArguments' in ASTBuilder
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Trivial
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-28 19:46 PST by Han Choongwoo
Modified: 2015-02-04 09:16 PST (History)
1 user (show)

See Also:

Attachments
Patch (2.88 KB, patch)
2015-01-28 19:48 PST, Han Choongwoo 		darin: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Han Choongwoo 2015-01-28 19:46:34 PST 
The method name 'usesArguments' in ASTBuilder is confusing.
'usesArguments' is used as setter method in AST Builder.
In other files, usesArguments is getter method,
and 'setUsesArguments' is setter method.

So, it is better to rename usesArguments to setUsesArguments in ASTBuilder.
Comment 1 Han Choongwoo 2015-01-28 19:48:59 PST 
Created attachment 245604 [details]
Patch
Comment 2 Darin Adler 2015-02-04 09:16:11 PST 
Comment on attachment 245604 [details]
Patch

I don’t think it makes sense to change this function and not change the 4 other similarly-named ones, usesThis, usesCatch, usesWith, and usesEval. You should talk to the programmers who work on this code a lot and see if they are amendable to renaming all 5 of them.
Comment 3 Darin Adler 2015-02-04 09:16:40 PST 
(In reply to comment #2)
> amendable

I meant "amenable"