Bug 141015 - asan.xcconfig should use CLANG_ADDRESS_SANITIZER=YES instead of -fsanitize=address
Summary: asan.xcconfig should use CLANG_ADDRESS_SANITIZER=YES instead of -fsanitize=ad...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dana Burkart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-28 15:36 PST by Dana Burkart
Modified: 2015-01-28 16:30 PST (History)
3 users (show)

See Also:


Attachments
Remove -fsanitize=address and add CLANG_ADDRESS_SANITIZER=YES (1.23 KB, patch)
2015-01-28 15:45 PST, Dana Burkart
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dana Burkart 2015-01-28 15:36:18 PST
We should use CLANG_ADDRESS_SANITIZER=YES to build with ASan, since we use xcodebuild to do all of our (mac) building.
Comment 1 Dana Burkart 2015-01-28 15:45:48 PST
Created attachment 245573 [details]
Remove -fsanitize=address and add CLANG_ADDRESS_SANITIZER=YES
Comment 2 Alexey Proskuryakov 2015-01-28 16:19:54 PST
Comment on attachment 245573 [details]
Remove -fsanitize=address and add CLANG_ADDRESS_SANITIZER=YES

So we can remove ASAN_OTHER_LDFLAGS from everywhere now?
Comment 3 Dana Burkart 2015-01-28 16:21:26 PST
(In reply to comment #2)
> Comment on attachment 245573 [details]
> Remove -fsanitize=address and add CLANG_ADDRESS_SANITIZER=YES
> 
> So we can remove ASAN_OTHER_LDFLAGS from everywhere now?

Yeah, I don't see why not.
Comment 4 Dana Burkart 2015-01-28 16:30:19 PST
Resolved in r179312.