WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
141014
Remove more Mountain Lion code from WebCore
https://bugs.webkit.org/show_bug.cgi?id=141014
Summary
Remove more Mountain Lion code from WebCore
Beth Dakin
Reported
2015-01-28 15:23:37 PST
Remove more Mountain Lion code from WebCore
Attachments
Patch
(32.96 KB, patch)
2015-01-28 15:25 PST
,
Beth Dakin
no flags
Details
Formatted Diff
Diff
Patch
(32.83 KB, patch)
2015-01-28 16:46 PST
,
Beth Dakin
andersca
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Beth Dakin
Comment 1
2015-01-28 15:25:13 PST
Created
attachment 245572
[details]
Patch
Beth Dakin
Comment 2
2015-01-28 16:30:12 PST
Comment on
attachment 245572
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=245572&action=review
> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:-2019 > -#else
I think we need this #else!
Beth Dakin
Comment 3
2015-01-28 16:31:40 PST
Comment on
attachment 245572
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=245572&action=review
>> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:-2019 >> -#else > > I think we need this #else!
No, false alarm. Just the fide being dumb.
Beth Dakin
Comment 4
2015-01-28 16:46:22 PST
Created
attachment 245581
[details]
Patch Patch that uses more COCOA.
Anders Carlsson
Comment 5
2015-01-28 16:52:54 PST
Comment on
attachment 245581
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=245581&action=review
> Source/WebCore/crypto/CommonCryptoUtilities.h:41 > +#if defined(__has_include) && (PLATFORM(COCOA))
Can remove the () outside PLATFORM(COCOA)
> Source/WebCore/editing/cocoa/HTMLConverter.mm:1725 > +#if (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 80000) || PLATFORM(MAC)
This can also be PLATFORM(COCOA) - actually I think this is always going to be true inside HTMLConverter.mm!
> Source/WebCore/loader/cocoa/DiskCacheMonitorCocoa.mm:44 > -#if (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 80000) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090) > +#if (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 80000) || PLATFORM(MAC)
Can just remove the #if.
Beth Dakin
Comment 6
2015-01-29 13:58:40 PST
Thank you!
http://trac.webkit.org/changeset/179364
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug