Bug 140982 - Add API::{FrameInfo, NavigationAction, NavigationResponse} types
Summary: Add API::{FrameInfo, NavigationAction, NavigationResponse} types
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-27 20:12 PST by Tim Horton
Modified: 2015-01-28 19:05 PST (History)
5 users (show)

See Also:


Attachments
Patch (48.89 KB, patch)
2015-01-27 20:12 PST, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (48.94 KB, patch)
2015-01-28 03:11 PST, Tim Horton
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-01-27 20:12:03 PST
Add API::{FrameInfo, NavigationAction, NavigationResponse} types
Comment 1 Tim Horton 2015-01-27 20:12:23 PST
Created attachment 245512 [details]
Patch
Comment 2 WebKit Commit Bot 2015-01-27 20:14:49 PST
Attachment 245512 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKNavigationAction.mm:115:  The parameter name "frameInfo" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKNavigationAction.mm:122:  The parameter name "frameInfo" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:153:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:173:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:271:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:329:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 6 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2015-01-28 03:11:47 PST
Created attachment 245529 [details]
Patch
Comment 4 WebKit Commit Bot 2015-01-28 03:12:53 PST
Attachment 245529 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKNavigationAction.mm:115:  The parameter name "frameInfo" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKNavigationAction.mm:122:  The parameter name "frameInfo" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:153:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:173:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:271:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:329:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 6 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Sam Weinig 2015-01-28 11:58:30 PST
Comment on attachment 245529 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245529&action=review

> Source/WebKit2/UIProcess/API/APIFrameInfo.h:45
> +    FrameInfo(const WebKit::WebFrameProxy&);

I would mark this as explicit.

> Source/WebKit2/UIProcess/API/APIFrameInfo.h:47
> +    ~FrameInfo()

I would mark this as virtual. I'm actually not sure if you need it at all.

> Source/WebKit2/UIProcess/API/APINavigationAction.h:54
> +    ~NavigationAction()

Same comment as the FrameInfo destructor.

> Source/WebKit2/UIProcess/API/APINavigationResponse.h:52
> +    ~NavigationResponse()

Same comment as the FrameInfo destructor.
Comment 6 Tim Horton 2015-01-28 19:05:45 PST
http://trac.webkit.org/changeset/179328