Bug 140981 - Use an enum class for createFontFamilyValue()'s fromSystemFontID argument
Summary: Use an enum class for createFontFamilyValue()'s fromSystemFontID argument
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-27 20:03 PST by Chris Dumez
Modified: 2015-01-28 10:24 PST (History)
2 users (show)

See Also:


Attachments
Patch (5.43 KB, patch)
2015-01-27 20:07 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-01-27 20:03:45 PST
Use an enum class for createFontFamilyValue()'s fromSystemFontID argument instead of a simple enum.
Comment 1 Chris Dumez 2015-01-27 20:07:18 PST
Created attachment 245511 [details]
Patch
Comment 2 WebKit Commit Bot 2015-01-27 20:09:49 PST
Attachment 245511 [details] did not pass style-queue:


ERROR: Source/WebCore/css/CSSValuePool.cpp:132:  Missing space before {  [whitespace/braces] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2015-01-28 10:24:49 PST
Comment on attachment 245511 [details]
Patch

Clearing flags on attachment: 245511

Committed r179267: <http://trac.webkit.org/changeset/179267>
Comment 4 WebKit Commit Bot 2015-01-28 10:24:53 PST
All reviewed patches have been landed.  Closing bug.