Bug 140979 - Rename descendentxxx to descendantxxxx in RenderLayerBacking
Summary: Rename descendentxxx to descendantxxxx in RenderLayerBacking
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-27 19:32 PST by Jeongmin Kim
Modified: 2015-01-28 00:09 PST (History)
6 users (show)

See Also:


Attachments
Patch (7.11 KB, patch)
2015-01-27 19:38 PST, Jeongmin Kim
no flags Details | Formatted Diff | Diff
Patch (8.00 KB, patch)
2015-01-27 19:47 PST, Jeongmin Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeongmin Kim 2015-01-27 19:32:58 PST
Rename descendentxxx to descendantxxxx in RenderLayerBacking
Comment 1 Jeongmin Kim 2015-01-27 19:38:10 PST
Created attachment 245507 [details]
Patch
Comment 2 Jeongmin Kim 2015-01-27 19:47:21 PST
Created attachment 245510 [details]
Patch
Comment 3 Simon Fraser (smfr) 2015-01-27 20:48:03 PST
Thanks for doing this, but I'm not sure it's quite accurate.

FYI, the dictionary says:

"usage: The correct spelling for the noun meaning ‘person descended from a particular ancestor’ is descendant, ending with the suffix -ant, not -ent (as in she claims to be a descendant of Paul Revere). The word descendent is an adjective, now used almost exclusively in scientific contexts, meaning ‘descending from an ancestor’ (as in extinct species are replaced by descendent species). Almost 15 percent of the citations for the noun in the Oxford English Corpus use the wrong spelling."

Our usage sometimes follows the adjectival form, so I don't think we're using the -ent for incorrectly.
Comment 4 Byungseon Shin 2015-01-27 21:09:15 PST
@Simon, we are totally agree with your idea. 
However, from a debugging perspective, it is a little hard to track logic if there are two different words are used for same meaning in a one file. 
So, we want to enhance the readability of the code itself.
Comment 5 Simon Fraser (smfr) 2015-01-27 23:20:28 PST
I do not object to the patch. I think consistency is good.
Comment 6 WebKit Commit Bot 2015-01-28 00:09:26 PST
Comment on attachment 245510 [details]
Patch

Clearing flags on attachment: 245510

Committed r179244: <http://trac.webkit.org/changeset/179244>
Comment 7 WebKit Commit Bot 2015-01-28 00:09:30 PST
All reviewed patches have been landed.  Closing bug.