Bug 140967 – Immediate action gesture recognizer still doesn't work well with IB

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

[Beth Dakin]

Immediate action gesture recognizer still doesn't work well with IB

rdar://problem/19621509

[Beth Dakin]

Created attachment 245489 [details]
Patch

[Tim Horton]

Comment on attachment 245489 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245489&action=review

> Source/WebKit2/UIProcess/API/mac/WKView.mm:2571
> +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000

It looks to me (with a tiny test app) like you're not guaranteed to move to a nil window when moving between windows, so I think this needs to be restructured to avoid re-adding the GR.

> Source/WebKit2/UIProcess/API/mac/WKView.mm:2576
> +            [self addGestureRecognizer:_data->_immediateActionGestureRecognizer.get()];

We could keep the controller/GR instantiation in init/commoninit and just add/remove here, for minimal change, if you want.

> Source/WebKit2/UIProcess/API/mac/WKView.mm:2593
> +        if (NSClassFromString(@"NSImmediateActionGestureRecognizer"))

This could check _immediateActionGestureRecognizer instead of this.

[Beth Dakin]

Created attachment 245494 [details]
Patch

[Tim Horton]

Comment on attachment 245494 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245494&action=review

> Source/WebKit/mac/WebView/WebView.mm:5300
> +            if (![[self gestureRecognizers] containsObject:recognizer])

As discussed, I think we should not add the GR if _data->_ignoresNonWheelEvents is true.

[Beth Dakin]

Thank you! http://trac.webkit.org/changeset/179230