Bug 140961 - Web Inspector: remove CSS.setPropertyText, CSS.toggleProperty and related dead code
Summary: Web Inspector: remove CSS.setPropertyText, CSS.toggleProperty and related dea...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brian Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-01-27 14:55 PST by Brian Burg
Modified: 2017-09-12 16:50 PDT (History)
8 users (show)

See Also:

Attachments
Patch (75.93 KB, patch)
2015-01-27 14:59 PST, Brian Burg 		no flags Details | Formatted Diff | Diff
Removed a few more members (82.98 KB, patch)
2015-01-27 20:57 PST, Brian Burg 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2015-01-27 14:55:45 PST 
heh. wow.
Comment 1 Radar WebKit Bug Importer 2015-01-27 14:56:16 PST 
<rdar://problem/19621042>
Comment 2 Brian Burg 2015-01-27 14:59:02 PST 
Created attachment 245477 [details]
Patch
Comment 3 Timothy Hatcher 2015-01-27 17:53:57 PST 
Comment on attachment 245477 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245477&action=review

Nice!

> Source/WebCore/inspector/InspectorStyleSheet.cpp:-1247
> -    m_inspectorStyles.set(inspectorStyle->cssStyle(), inspectorStyle);

I think we can remove m_inspectorStyles.
Comment 4 Brian Burg 2015-01-27 20:57:30 PST 
Created attachment 245514 [details]
Removed a few more members
Comment 5 WebKit Commit Bot 2015-01-28 13:45:01 PST 
Comment on attachment 245514 [details]
Removed a few more members

Clearing flags on attachment: 245514

Committed r179286: <http://trac.webkit.org/changeset/179286>
Comment 6 WebKit Commit Bot 2015-01-28 13:45:05 PST 
All reviewed patches have been landed.  Closing bug.