Bug 140955 - [WebAudio] AudioBufferSourceNodes should accurately play backwards if given a negative playbackRate.
Summary: [WebAudio] AudioBufferSourceNodes should accurately play backwards if given a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on: 141263
Blocks:
  Show dependency tree / graph
 
Reported: 2015-01-27 13:51 PST by Jer Noble
Modified: 2015-02-09 11:46 PST (History)
4 users (show)

See Also:

Attachments
Patch (689.66 KB, patch)
2015-01-28 10:17 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-mavericks (1.57 MB, application/zip)
2015-01-28 11:06 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews107 for mac-mavericks-wk2 (1.69 MB, application/zip)
2015-01-28 11:11 PST, Build Bot 		no flags Details
Patch (693.08 KB, patch)
2015-01-28 15:54 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (26.97 KB, patch)
2015-02-06 22:00 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2015-01-27 13:51:22 PST 
[WebAudio] AudioBufferSourceNodes should accurately play backwards if given a negative playbackRate.
Comment 1 Jer Noble 2015-01-28 10:17:31 PST 
Created attachment 245551 [details]
Patch
Comment 2 Build Bot 2015-01-28 11:06:14 PST 
Comment on attachment 245551 [details]
Patch

Attachment 245551 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4723800142774272

New failing tests:
webaudio/audiobuffersource-start.html
webaudio/note-grain-on-play.html
webaudio/audiobuffersource-negative-playbackrate.html
webaudio/note-grain-on-timing.html
webaudio/audiobuffersource-negative-playbackrate-interpolated.html
Comment 3 Build Bot 2015-01-28 11:06:17 PST 
Created attachment 245554 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 4 Build Bot 2015-01-28 11:11:42 PST 
Comment on attachment 245551 [details]
Patch

Attachment 245551 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5007196043608064

New failing tests:
webaudio/audiobuffersource-start.html
webaudio/note-grain-on-play.html
webaudio/audiobuffersource-negative-playbackrate.html
webaudio/note-grain-on-timing.html
webaudio/audiobuffersource-negative-playbackrate-interpolated.html
Comment 5 Build Bot 2015-01-28 11:11:46 PST 
Created attachment 245555 [details]
Archive of layout-test-results from ews107 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 6 Jer Noble 2015-01-28 15:54:26 PST 
Created attachment 245574 [details]
Patch
Comment 7 WebKit Commit Bot 2015-02-04 11:37:45 PST 
Comment on attachment 245574 [details]
Patch

Clearing flags on attachment: 245574

Committed r179618: <http://trac.webkit.org/changeset/179618>
Comment 8 WebKit Commit Bot 2015-02-04 11:37:50 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 WebKit Commit Bot 2015-02-04 14:38:42 PST 
Re-opened since this is blocked by bug 141263
Comment 10 Jer Noble 2015-02-06 22:00:25 PST 
Created attachment 246198 [details]
Patch for landing
Comment 11 WebKit Commit Bot 2015-02-09 11:45:58 PST 
Comment on attachment 246198 [details]
Patch for landing

Clearing flags on attachment: 246198

Committed r179838: <http://trac.webkit.org/changeset/179838>
Comment 12 WebKit Commit Bot 2015-02-09 11:46:02 PST 
All reviewed patches have been landed.  Closing bug.