Bug 140949 - [iOS] run-webkit-tests --platform=ios* --lint-test-files does not work
Summary: [iOS] run-webkit-tests --platform=ios* --lint-test-files does not work
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad iOS 8.1
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-27 12:05 PST by Daniel Bates
Modified: 2015-02-28 17:25 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.22 KB, patch)
2015-01-27 12:20 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
Patch (3.15 KB, patch)
2015-01-27 14:03 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2015-01-27 12:05:53 PST 
run-webkit-tests --platform=ios* --lint-test-files does not link check the iOS TestExpectation files.
Comment 1 Daniel Bates 2015-01-27 12:19:25 PST 
Notice that it is sufficient to include "ios-simulator" in the list of ports without builders so as to lint TestExpectation files LayoutTests/platform/ios-simulator/TestExpectations and LayoutTests/platform/ios-simulator-wk1/TestExpectations by <http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/lint_test_expectations.py?rev=160756#L56> and <http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/port/factory.py?rev=179162#L124> and <http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/port/ios.py?rev=179199#L179>.

A similar argument can be made to show that ios-simulator-wk2 will instantiate a IOSSimulatorPort object where IOSSimulatorPort.get_option('webkit_test_runner') evaluates to true and hence we will lint LayoutTests/platform/ios-simulator-wk2/TestExpectations by <http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/port/ios.py?rev=179199#L177>.
Comment 2 Daniel Bates 2015-01-27 12:20:26 PST 
Created attachment 245460 [details]
Patch
Comment 3 Daniel Bates 2015-01-27 14:03:01 PST 
Created attachment 245467 [details]
Patch
Comment 4 Daniel Bates 2015-01-27 14:07:48 PST 
Comment on attachment 245467 [details]
Patch

Clearing flags on attachment: 245467

Committed r179216: <http://trac.webkit.org/changeset/179216>
Comment 5 Daniel Bates 2015-01-27 14:07:52 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 David Kilzer (:ddkilzer) 2015-02-28 17:25:25 PST 
(In reply to comment #4)
> Comment on attachment 245467 [details]
> Patch
> 
> Clearing flags on attachment: 245467
> 
> Committed r179216: <http://trac.webkit.org/changeset/179216>

FWIW, this fix regressed this performance fix:

Bug 135409: [iOS] run-webkit-tests runs webkit-build-directory on every test

However, that regression was fixed by r180845:
<http://trac.webkit.org/changeset/180845>