To cleanup FlowContents's interface.
Created attachment 245456 [details] Patch
Comment on attachment 245456 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245456&action=review > Source/WebCore/rendering/SimpleLineLayoutFlowContents.h:86 > mutable LazyLineBreakIterator m_lineBreakIterator; Should this move down too? > Source/WebCore/rendering/SimpleLineLayoutFlowContents.h:90 > +class FlowContentsIterator : public FlowContents { I'd prefer FlowContentsIterator to have FlowContents instead of being one.
Comment on attachment 245456 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245456&action=review >> Source/WebCore/rendering/SimpleLineLayoutFlowContents.h:90 >> +class FlowContentsIterator : public FlowContents { > > I'd prefer FlowContentsIterator to have FlowContents instead of being one. You should split this to two files at some point.
Created attachment 245540 [details] Patch
Created attachment 245552 [details] Patch
Created attachment 245565 [details] Patch
Comment on attachment 245565 [details] Patch Clearing flags on attachment: 245565 Committed r179284: <http://trac.webkit.org/changeset/179284>
All reviewed patches have been landed. Closing bug.