Bug 140944 - Simple line layout: Move FlowContents iterator interface to FlowContentsIterator.
Summary: Simple line layout: Move FlowContents iterator interface to FlowContentsItera...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-27 11:04 PST by zalan
Modified: 2015-01-28 13:37 PST (History)
6 users (show)

See Also:


Attachments
Patch (27.49 KB, patch)
2015-01-27 11:16 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (50.19 KB, patch)
2015-01-28 07:22 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (50.27 KB, patch)
2015-01-28 10:32 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (53.22 KB, patch)
2015-01-28 12:38 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2015-01-27 11:04:08 PST
To cleanup FlowContents's interface.
Comment 1 zalan 2015-01-27 11:16:31 PST
Created attachment 245456 [details]
Patch
Comment 2 Antti Koivisto 2015-01-27 11:26:46 PST
Comment on attachment 245456 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245456&action=review

> Source/WebCore/rendering/SimpleLineLayoutFlowContents.h:86
>      mutable LazyLineBreakIterator m_lineBreakIterator;

Should this move down too?

> Source/WebCore/rendering/SimpleLineLayoutFlowContents.h:90
> +class FlowContentsIterator : public FlowContents {

I'd prefer FlowContentsIterator to have FlowContents instead of being one.
Comment 3 Antti Koivisto 2015-01-27 11:27:29 PST
Comment on attachment 245456 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245456&action=review

>> Source/WebCore/rendering/SimpleLineLayoutFlowContents.h:90
>> +class FlowContentsIterator : public FlowContents {
> 
> I'd prefer FlowContentsIterator to have FlowContents instead of being one.

You should split this to two files at some point.
Comment 4 zalan 2015-01-28 07:22:53 PST
Created attachment 245540 [details]
Patch
Comment 5 zalan 2015-01-28 10:32:21 PST
Created attachment 245552 [details]
Patch
Comment 6 zalan 2015-01-28 12:38:38 PST
Created attachment 245565 [details]
Patch
Comment 7 WebKit Commit Bot 2015-01-28 13:37:41 PST
Comment on attachment 245565 [details]
Patch

Clearing flags on attachment: 245565

Committed r179284: <http://trac.webkit.org/changeset/179284>
Comment 8 WebKit Commit Bot 2015-01-28 13:37:45 PST
All reviewed patches have been landed.  Closing bug.