Bug 140929 – [MSE] Setting timestampOffset does not change the timestamps in the actual sample, leading to visual and audible errors.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

[MSE] Setting timestampOffset does not change the timestamps in the actual sample, leading to visual and audible errors.

[Jer Noble]

Created attachment 245430 [details]
Patch

[Darin Adler]

Comment on attachment 245430 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245430&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:550
> +    timingInfoArray.resize(itemCount);

This should use grow rather than resize since we know itemCount is >= timingInfoArray.size().

[Jer Noble]

Created attachment 245942 [details]
Patch for landing

[Jer Noble]

<rdar://problem/19627056>

[WebKit Commit Bot]

Comment on attachment 245942 [details]
Patch for landing

Clearing flags on attachment: 245942

Committed r179564: <http://trac.webkit.org/changeset/179564>

[Alexey Proskuryakov]

This broke http/tests/media/media-source/mediasource-config-change-mp4-v-framerate.html on some testers:

https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fmedia%2Fmedia-source%2Fmediasource-config-change-mp4-v-framerate.html

[Jer Noble]

Created attachment 245974 [details]
Follow-up patch to fix broken test

[WebKit Commit Bot]

Comment on attachment 245974 [details]
Follow-up patch to fix broken test

Clearing flags on attachment: 245974

Committed r179577: <http://trac.webkit.org/changeset/179577>