Bug 140929 - [MSE] Setting timestampOffset does not change the timestamps in the actual sample, leading to visual and audible errors.
Summary: [MSE] Setting timestampOffset does not change the timestamps in the actual sa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-01-27 01:26 PST by Jer Noble
Modified: 2015-02-07 00:06 PST (History)
3 users (show)

See Also:

Attachments
Patch (13.89 KB, patch)
2015-01-27 01:33 PST, Jer Noble 		darin: review+
Details | Formatted Diff | Diff
Patch for landing (13.84 KB, patch)
2015-02-03 08:42 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Follow-up patch to fix broken test (2.33 KB, patch)
2015-02-03 15:13 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2015-01-27 01:26:18 PST 
[MSE] Setting timestampOffset does not change the timestamps in the actual sample, leading to visual and audible errors.
Comment 1 Jer Noble 2015-01-27 01:33:37 PST 
Created attachment 245430 [details]
Patch
Comment 2 Darin Adler 2015-01-28 09:23:23 PST 
Comment on attachment 245430 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245430&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:550
> +    timingInfoArray.resize(itemCount);

This should use grow rather than resize since we know itemCount is >= timingInfoArray.size().
Comment 3 Jer Noble 2015-02-03 08:42:31 PST 
Created attachment 245942 [details]
Patch for landing
Comment 4 Jer Noble 2015-02-03 12:24:34 PST 
<rdar://problem/19627056>
Comment 5 WebKit Commit Bot 2015-02-03 13:09:21 PST 
Comment on attachment 245942 [details]
Patch for landing

Clearing flags on attachment: 245942

Committed r179564: <http://trac.webkit.org/changeset/179564>
Comment 6 Alexey Proskuryakov 2015-02-03 14:08:53 PST 
This broke http/tests/media/media-source/mediasource-config-change-mp4-v-framerate.html on some testers:

https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fmedia%2Fmedia-source%2Fmediasource-config-change-mp4-v-framerate.html
Comment 7 Jer Noble 2015-02-03 15:13:56 PST 
Created attachment 245974 [details]
Follow-up patch to fix broken test
Comment 8 WebKit Commit Bot 2015-02-03 16:07:55 PST 
Comment on attachment 245974 [details]
Follow-up patch to fix broken test

Clearing flags on attachment: 245974

Committed r179577: <http://trac.webkit.org/changeset/179577>