RESOLVED FIXED 140916
AX: [ATK] Implement support for new AtkRole types for MathML
https://bugs.webkit.org/show_bug.cgi?id=140916
Summary AX: [ATK] Implement support for new AtkRole types for MathML
Joanmarie Diggs
Reported 2015-01-26 18:42:09 PST
ATK 2.15.4 has four new roles applicable to MathML: * ATK_ROLE_MATH_FRACTION * ATK_ROLE_MATH_ROOT * ATK_ROLE_SUBSCRIPT * ATK_ROLE_SUPERSCRIPT We should implement support for them. Note that in the case of subscript and superscript, the {sub,super}script functionally is not the {msub,msup} element (which includes the base). Therefore, I think what makes the most sense is to expose the script container as ATK_ROLE_SECTION (the generic textblock role) and then expose its children (the functional sub/sup) using the new roles.
Attachments
Patch (21.82 KB, patch)
2015-01-26 18:59 PST, Joanmarie Diggs
no flags
Patch (21.78 KB, patch)
2015-01-26 21:16 PST, Joanmarie Diggs
no flags
Patch (22.50 KB, patch)
2015-01-26 22:21 PST, Joanmarie Diggs
no flags
Patch (29.44 KB, patch)
2015-01-27 15:45 PST, Joanmarie Diggs
no flags
Radar WebKit Bug Importer
Comment 1 2015-01-26 18:42:22 PST
Joanmarie Diggs
Comment 2 2015-01-26 18:59:26 PST
Joanmarie Diggs
Comment 3 2015-01-26 19:01:34 PST
NOT yet asking for review. I generated results for the Mac and am hoping they'll match for Mountain Lion and Mavericks. Tossing them at EWS to see. Ditto for the jhbuild ATK version bump for Gtk.
Joanmarie Diggs
Comment 4 2015-01-26 20:08:41 PST
Ok, NOW I'm asking for review. :) @Chris: If you have time to review this, that would be awesome. @Carlos: This is a heads up and request for you to bless (or deny) the jhbuild ATK version bump once I have a patch that passes review. To see what we will be able to regression test from the bump, compare the Gtk+ test changes to the Efl ones. Thanks guys!
Joanmarie Diggs
Comment 5 2015-01-26 20:13:32 PST
Comment on attachment 245399 [details] Patch Clearing flag. New version coming up. Sorry for the noise.
Joanmarie Diggs
Comment 6 2015-01-26 21:16:38 PST
chris fleizach
Comment 7 2015-01-26 21:35:21 PST
Comment on attachment 245414 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245414&action=review > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:3617 > + return this == parentObjectUnignored()->mathSuperscriptObject(); I think we should check if parentObjectUnignored() returns nullptr before calling that method on it. > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:3628 > + if (!parent or !parent->isMathMultiscript()) or -> || (is 'or' being used in WebKit in other places?) > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:3633 > + for (const auto& pair : pairs) { can you add some comments what this is trying to determine? > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:3641 > + for (const auto& pair : pairs) { and here too
Joanmarie Diggs
Comment 8 2015-01-26 22:21:40 PST
Joanmarie Diggs
Comment 9 2015-01-26 23:11:04 PST
(In reply to comment #7) > I think we should check if parentObjectUnignored() returns nullptr before > calling that method on it. Done. > or -> || (is 'or' being used in WebKit in other places?) Done. (Was multitasking with some Python code. Apologies.) > can you add some comments what this is trying to determine? Done.
Joanmarie Diggs
Comment 10 2015-01-27 06:21:57 PST
Martin: This is a heads up and request for you to bless (or deny) the jhbuild ATK version bump once I have a patch that passes review. To see what we will be able to regression test from the bump, compare the Gtk+ test changes to the Efl ones. (Carlos says he's ok with it, but to check with you.)
chris fleizach
Comment 11 2015-01-27 08:38:23 PST
Comment on attachment 245423 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245423&action=review thanks! > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:3642 > + // this token is present as the second item. With these comments, I see that I think we can probably combine these methods into one like isMathMultiscriptObject(AccessibilityMathMultiscriptType type)
Joanmarie Diggs
Comment 12 2015-01-27 08:51:10 PST
(In reply to comment #11) > Comment on attachment 245423 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=245423&action=review > > thanks! > > > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:3642 > > + // this token is present as the second item. > > With these comments, I see that I think we can probably combine these > methods into one like > > isMathMultiscriptObject(AccessibilityMathMultiscriptType type) Sure, but then how do I know if it's a subscript or a superscript? The goal is to distinguish them.
Joanmarie Diggs
Comment 13 2015-01-27 08:51:38 PST
(In reply to comment #12) > (In reply to comment #11) > > Comment on attachment 245423 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=245423&action=review > > > > thanks! > > > > > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:3642 > > > + // this token is present as the second item. > > > > With these comments, I see that I think we can probably combine these > > methods into one like > > > > isMathMultiscriptObject(AccessibilityMathMultiscriptType type) > > Sure, but then how do I know if it's a subscript or a superscript? The goal > is to distinguish them. Never mind. Misread.
Joanmarie Diggs
Comment 14 2015-01-27 15:45:09 PST
WebKit Commit Bot
Comment 15 2015-01-28 09:02:34 PST
Comment on attachment 245487 [details] Patch Clearing flags on attachment: 245487 Committed r179253: <http://trac.webkit.org/changeset/179253>
WebKit Commit Bot
Comment 16 2015-01-28 09:02:39 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.