Bug 140911 - Invoking an immediate action on link often dismisses selection
Summary: Invoking an immediate action on link often dismisses selection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-26 16:50 PST by Beth Dakin
Modified: 2015-01-27 11:14 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.71 KB, patch)
2015-01-26 16:53 PST, Beth Dakin 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2015-01-26 16:50:51 PST 
Invoking an immediate action on link often dismisses existing selection. It should not.

rdar://problem/19572685
Comment 1 Beth Dakin 2015-01-26 16:53:22 PST 
Created attachment 245391 [details]
Patch
Comment 2 Tim Horton 2015-01-26 20:16:55 PST 
Comment on attachment 245391 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245391&action=review

> Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:-210
> -    _page->setMaintainsInactiveSelection(false);

I don't think we can get rid of this one, can we?
Comment 3 Beth Dakin 2015-01-27 11:14:44 PST 
(In reply to comment #2)
> Comment on attachment 245391 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=245391&action=review
> 
> > Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:-210
> > -    _page->setMaintainsInactiveSelection(false);
> 
> I don't think we can get rid of this one, can we?

It actually seems like dismissContentRelativeChildWindows is typically called through WKView code on cancel, but it seems best not to rely on that, so I kept this one. There is certainly no downside.

http://trac.webkit.org/changeset/179195