Bug 140907 - WebGL2: Disable various extensions on WebGL2 context that have been promoted to core
Summary: WebGL2: Disable various extensions on WebGL2 context that have been promoted ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-26 16:04 PST by Roger Fong
Modified: 2015-01-27 17:16 PST (History)
3 users (show)

See Also:


Attachments
patch (27.85 KB, patch)
2015-01-26 16:06 PST, Roger Fong
no flags Details | Formatted Diff | Diff
patch (29.31 KB, patch)
2015-01-26 16:38 PST, Roger Fong
no flags Details | Formatted Diff | Diff
patch (29.33 KB, patch)
2015-01-26 16:41 PST, Roger Fong
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Fong 2015-01-26 16:04:06 PST
To disable:
WEBGL_lose_context 
OES_standard_derivatives 
OES_vertex_array_object 
OES_element_index_uint 
WEBGL_draw_buffers 
ANGLE_instanced_arrays 
EXT_frag_depth 
EXT_sRGB 
EXT_blend_minmax 
EXT_shader_texture_lod

Comment 1 Roger Fong 2015-01-26 16:04:35 PST
rdar://problem/19545857
Comment 2 Roger Fong 2015-01-26 16:06:55 PST
Created attachment 245383 [details]
patch
Comment 3 Roger Fong 2015-01-26 16:38:53 PST
Created attachment 245388 [details]
patch
Comment 4 WebKit Commit Bot 2015-01-26 16:40:36 PST
Attachment 245388 [details] did not pass style-queue:


ERROR: LayoutTests/ChangeLog:3:  Line contains tab character.  [whitespace/tab] [5]
ERROR: LayoutTests/ChangeLog:4:  Line contains tab character.  [whitespace/tab] [5]
ERROR: LayoutTests/ChangeLog:5:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 3 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Roger Fong 2015-01-26 16:41:42 PST
Created attachment 245389 [details]
patch
Comment 6 Brent Fulgham 2015-01-27 15:02:07 PST
Comment on attachment 245389 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245389&action=review

r=me, but please get rid of the tab characters in the LayoutTests/ChangeLog file.

> LayoutTests/ChangeLog:5
> +        <rdar://problem/19545857>

Please get rid of the tabs.
Comment 7 Roger Fong 2015-01-27 16:32:08 PST
Comment on attachment 245389 [details]
patch

The tab errors were actually from a previously uploaded patch. The current one here should be okay on the tabs. Thanks!
Comment 8 WebKit Commit Bot 2015-01-27 17:16:34 PST
Comment on attachment 245389 [details]
patch

Clearing flags on attachment: 245389

Committed r179233: <http://trac.webkit.org/changeset/179233>
Comment 9 WebKit Commit Bot 2015-01-27 17:16:37 PST
All reviewed patches have been landed.  Closing bug.