Bug 140898 - Web Inspector: DebuggerSidebarPanel: _addBreakpoint function has unnecessary parameter
Summary: Web Inspector: DebuggerSidebarPanel: _addBreakpoint function has unnecessary ...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jonathan Wells
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-01-26 13:12 PST by Jonathan Wells
Modified: 2016-08-04 17:57 PDT (History)
7 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Wells 2015-01-26 13:12:24 PST 
Near line 310 of the DebuggerSidebarPanel.js file is this call:

    this._addBreakpoint(breakpoints[i], sourceCode);

However this function begins:

    _addBreakpoint: function(breakpoint, sourceCode)
    {
        var sourceCode = breakpoint.sourceCodeLocation.displaySourceCode;

Clearly this second parameter is unnecessary.
Comment 1 Radar WebKit Bug Importer 2015-01-26 13:12:53 PST 
<rdar://problem/19603573>
Comment 2 Radar WebKit Bug Importer 2015-01-26 13:12:58 PST 
<rdar://problem/19603574>
Comment 3 Matt Baker 2016-08-04 17:57:48 PDT 
The function in question has changed since this was filed, and this is no longer an issue.