Bug 140862 - Long spins under Frame::rangeForPoint when doing Lookup on feedly.com
Summary: Long spins under Frame::rangeForPoint when doing Lookup on feedly.com
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-25 00:09 PST by Tim Horton
Modified: 2015-01-25 00:18 PST (History)
0 users

See Also:

Attachments
Patch (1.79 KB, patch)
2015-01-25 00:10 PST, Tim Horton 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-01-25 00:09:34 PST 
Long spins under Frame::rangeForPoint when doing Lookup on feedly.com
Comment 1 Tim Horton 2015-01-25 00:10:03 PST 
Created attachment 245296 [details]
Patch
Comment 2 mitz 2015-01-25 00:12:59 PST 
Comment on attachment 245296 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245296&action=review

> Source/WebCore/page/Frame.cpp:856
> +    if (!containerText)
> +        return nullptr;
> +    if (!containerText->renderer() || containerText->renderer()->style().userSelect() == SELECT_NONE)

I’d combine these into one condition.
Comment 3 Tim Horton 2015-01-25 00:18:06 PST 
http://trac.webkit.org/changeset/179086