Bug 140849 – [Win] Cursor copy constructor does not initialize scale factor

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Brent Fulgham]

The following layout test is failing on [insert platform]

fast/events/mouse-cursor-image-set.html

Probable cause:

Based on the failure, it looks like the scale factor is not getting properly initialized or reported to JS:

--- /home/buildbot/slave/windows-release-tests/build/OpenSource/layout-test-results/fast/events/mouse-cursor-image-set-expected.txt
+++ /home/buildbot/slave/windows-release-tests/build/OpenSource/layout-test-results/fast/events/mouse-cursor-image-set-actual.txt
@@ -9,72 +9,72 @@
 Checking cursors with device pixel ratio of 1
 ----------------------------------------------
 TEST CASE: 25x25 image at 1x
-Cursor Info: type=Custom hotSpot=0,0 image=25x25
+Cursor Info: type=Custom hotSpot=0,0 image=25x25 scale=8.7643683e-34
 
 TEST CASE: 25x25 image at 2x
-Cursor Info: type=Custom hotSpot=0,0 image=25x25 scale=2
+Cursor Info: type=Custom hotSpot=0,0 image=25x25 scale=2.2420775e-44
 
 TEST CASE: 25x25 image at 1x, 30x30 image at 2x
-Cursor Info: type=Custom hotSpot=0,0 image=25x25
+Cursor Info: type=Custom hotSpot=0,0 image=25x25 scale=2.2420775e-44
 
[... etc. ...]

[Brent Fulgham]

The following tests fail due to this bug:

fast/events/mouse-cursor-change.html
fast/events/mouse-cursor-image-set.html
fast/events/mouse-cursor-multiframecur.html
fast/events/mouse-cursor-no-mousemove.html
fast/events/mouse-cursor.html

[Brent Fulgham]

Created attachment 245275 [details]
Patch

[Brent Fulgham]

Committed r179056: <http://trac.webkit.org/changeset/179056>

[Brent Fulgham]

Note: A build fix was needed for Mac:

Committed r179057: <https://trac.webkit.org/changeset/179057>