Bug 140844 - Implement cache size limit
Summary: Implement cache size limit
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antti Koivisto
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-23 15:56 PST by Antti Koivisto
Modified: 2015-01-23 17:30 PST (History)
0 users

See Also:


Attachments
Patch (7.14 KB, patch)
2015-01-23 16:13 PST, Antti Koivisto
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2015-01-23 15:56:47 PST
Don't grow without limits.
Comment 1 Antti Koivisto 2015-01-23 16:13:12 PST
Created attachment 245257 [details]
Patch
Comment 2 Andreas Kling 2015-01-23 17:24:00 PST
Comment on attachment 245257 [details]
Patch

r=me
Comment 3 Chris Dumez 2015-01-23 17:27:08 PST
Comment on attachment 245257 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245257&action=review

> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorageCocoa.mm:448
> +    m_maximumSize = 90 << 20;

What is this? m_maximumSize is initialized twice in a row.
Comment 4 Andreas Kling 2015-01-23 17:30:49 PST
Comment on attachment 245257 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245257&action=review

> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorageCocoa.mm:502
> +                unlink(path.data());

Don't we have a WebCore abstraction for this?