WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
140844
Implement cache size limit
https://bugs.webkit.org/show_bug.cgi?id=140844
Summary
Implement cache size limit
Antti Koivisto
Reported
2015-01-23 15:56:47 PST
Don't grow without limits.
Attachments
Patch
(7.14 KB, patch)
2015-01-23 16:13 PST
,
Antti Koivisto
kling
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Antti Koivisto
Comment 1
2015-01-23 16:13:12 PST
Created
attachment 245257
[details]
Patch
Andreas Kling
Comment 2
2015-01-23 17:24:00 PST
Comment on
attachment 245257
[details]
Patch r=me
Chris Dumez
Comment 3
2015-01-23 17:27:08 PST
Comment on
attachment 245257
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=245257&action=review
> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorageCocoa.mm:448 > + m_maximumSize = 90 << 20;
What is this? m_maximumSize is initialized twice in a row.
Andreas Kling
Comment 4
2015-01-23 17:30:49 PST
Comment on
attachment 245257
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=245257&action=review
> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorageCocoa.mm:502 > + unlink(path.data());
Don't we have a WebCore abstraction for this?
Ahmad Saleem
Comment 5
2022-10-25 13:25:13 PDT
Landed and didn't backed out -
https://github.com/WebKit/WebKit/commit/5a15d2a371ed6d244e4bcf6b2d4fc6d029496ce9
Marking this as "RESOLVED FIXED".
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug